SIMSBIOHUB 881: Adding Ticket ID to Data Request#359
Open
Conversation
|
OpenShift URLs for the PR Deployment:
|
|
|
OpenShift URLs for the PR Deployment:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Links to Jira Tickets
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-881
Description of Changes
Database – Adds
ticket_idtodata_request: migration addsticket_id(UUID, NOT NULL), FK toticket(ticket_id), and indexdata_request_ticket_idx.API – Models – Data request models now include
ticket_id: added toDataRequest(Zod),FlatDataRequestWithStatus,DataRequestWithStatus, andCreateDataRequestPayload.API – OpenAPI & schema –
ticket_idadded to the data request response schema and OpenAPI spec (required, UUID, description: “ID of the ticket associated with this data request”).API – Data request creation – When a data request is created, a ticket is created first via a new private
DataRequestService.createTicket()(subject “Data Request”, description = request reason, priority “medium”). The new ticket’sticket_idis passed into the repository so each data request is stored with a non-nullticket_id.API – Repository –
DataRequestRepositoryselects and returnsticket_idin all relevant queries;createDataRequestaccepts and persiststicket_idin the payload.API – Utils –
_transformFlatDataRequestToNestedindata-request.tsincludesticket_idin the nested response so all service responses expose it.API – Tests – Data request service, repository, and route tests updated to use and assert
ticket_id; seeds updated so data requests are created with linked tickets.Testing Instructions
ticket_idpointing to a new ticket with subject “Data Request” and the request reason as description.ticket_idfor each data request.ticket_idexpectations.ticket_idvalues.