Skip to content

Comments

SIMSBIOHUB-874: Ensure GitHub workflows clean up ImageStream tags#1607

Merged
dylanrogowsky-oxd merged 2 commits intodevfrom
SIMSBIOHUB-874
Feb 11, 2026
Merged

SIMSBIOHUB-874: Ensure GitHub workflows clean up ImageStream tags#1607
dylanrogowsky-oxd merged 2 commits intodevfrom
SIMSBIOHUB-874

Conversation

@dylanrogowsky-oxd
Copy link
Collaborator

@dylanrogowsky-oxd dylanrogowsky-oxd commented Feb 11, 2026

Links to Jira Tickets

Description of Changes

  • Single cleanup workflow: Renamed cleanClosedPR.yml to cleanPR.yml. It now runs whenever a PR is closed (merged or not) or converted back to draft, and removes that PR’s Helm release in dev plus all four image tags (app, api, db, db-setup) in -tools. We no longer have separate workflows for “closed” vs “merged.”
  • Removed cleanMergedPR.yml — its behaviour is covered by the updated cleanPR workflow.
  • deployStatic.yml: Replaced the post-deploy “clean” job with “pruneOldImageTags.” After a merge or manual run, we now prune old image tags for that environment (dev/test/prod) and keep only the 3 most recent per image, so ImageStream doesn’t accumulate tags. PR-specific cleanup is handled by cleanPR when the PR closes.
  • cleanPR tweaks: 20-minute timeout, and DB Setup image tag delete is now non-fatal if the tag doesn’t exist (aligned with the other images).

Testing Notes

  • Close a PR without merging and confirm cleanPR runs and removes the Helm release and the four image tags in -tools.
  • Merge a PR and confirm cleanPR runs and that deployStatic’s prune job keeps only the 3 most recent tags per image for that branch.
  • Convert a PR to draft and confirm cleanPR runs.
  • Optionally run deployStatic via workflow_dispatch and confirm the prune step completes without errors.

@dylanrogowsky-oxd dylanrogowsky-oxd added Do Not Merge PR should not be merged Not Ready For Review Addressing feedback and/or refactoring labels Feb 11, 2026
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.50%. Comparing base (0379182) to head (2986477).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1607      +/-   ##
==========================================
+ Coverage   33.05%   33.50%   +0.44%     
==========================================
  Files        1034     1035       +1     
  Lines       65196    65951     +755     
  Branches     2357     2490     +133     
==========================================
+ Hits        21553    22097     +544     
- Misses      43103    43270     +167     
- Partials      540      584      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dylanrogowsky-oxd dylanrogowsky-oxd added Ready For Review PR is ready for review and removed Do Not Merge PR should not be merged Not Ready For Review Addressing feedback and/or refactoring labels Feb 11, 2026
@dylanrogowsky-oxd dylanrogowsky-oxd marked this pull request as ready for review February 11, 2026 02:33
@dylanrogowsky-oxd dylanrogowsky-oxd marked this pull request as draft February 11, 2026 02:42
@dylanrogowsky-oxd dylanrogowsky-oxd marked this pull request as ready for review February 11, 2026 02:43
@sonarqubecloud
Copy link

@dylanrogowsky-oxd dylanrogowsky-oxd merged commit 7e65466 into dev Feb 11, 2026
21 checks passed
@dylanrogowsky-oxd dylanrogowsky-oxd deleted the SIMSBIOHUB-874 branch February 11, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready For Review PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant