SIMSBIOHUB-870: Align payload property names with BioHub#1608
Merged
dylanrogowsky-oxd merged 2 commits intodevfrom Feb 12, 2026
Merged
SIMSBIOHUB-870: Align payload property names with BioHub#1608dylanrogowsky-oxd merged 2 commits intodevfrom
dylanrogowsky-oxd merged 2 commits intodevfrom
Conversation
|
OpenShift URLs for the PR Deployment:
|
dylanrogowsky-oxd
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1608 +/- ##
==========================================
+ Coverage 33.05% 33.50% +0.44%
==========================================
Files 1034 1035 +1
Lines 65196 65951 +755
Branches 2357 2490 +133
==========================================
+ Hits 21553 22097 +544
- Misses 43103 43270 +167
- Partials 540 584 +44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dylanrogowsky-oxd
added
Do Not Merge
dylanrogowsky-oxd
force-pushed
the
SIMSBIOHUB-870
branch
from
e7e8595 to
1604b4f
Compare
|
dylanrogowsky-oxd
added
Ready For Review
|
OpenShift URLs for the PR Deployment:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
Description of Changes
environmental_condition_valuefor quantitative conditions instead ofenvironmental_quantitative_value, so both qualitative and quantitative use the same property name and match what the companion system expects.modeltodevice_modelto match the companion audit.artifact_key(from report attachment key),name(from title), andyear(from year_published) instead ofartifact_id,title, andyear_publishedso the payload matches the companion audit.Testing Notes
npm testin the api package — all tests pass. The only changes in this PR are the payload property names above and the corresponding test expectations; no behaviour change beyond what we send to the API.