15602 Merge Legal Name changes into main branch#538
Draft
severinbeauvais wants to merge 17 commits intomainfrom
Draft
15602 Merge Legal Name changes into main branch#538severinbeauvais wants to merge 17 commits intomainfrom
severinbeauvais wants to merge 17 commits intomainfrom
Conversation
* - app version = 4.8.0 - added temporary Legal API URL in example env file - added CSP entry for temp Legal API domain in firebase config - added temporary mapping for Legal Name API URL in vaults config - fixed timer id warning - added Alternate Name IF and property to Business Information IF - updated getOriginalLegalName to return operating name from entity snapshot for firms - fixed some typing issues * - used getOriginalLegalType where possible - removed some visibilty modifiers to fix template warnings - used getOriginalBusinessInfo where possible - added many fallbacks when setting potentially undefined values to the store - fixed some type warnings - sorted some Getters and Actions - used getOriginalNrNumber where possible - added a fallback for NAICS undo - deleted some unused Getters, etc - fixed type error in NrCorrectionIF - added EditingFlagsIF to clean up state model interface - added EmptyBusinessInfo to properly reset it in the store - added some conditional chaining (since some objects can be null/undefinedl) - changed direct access of legal name from entity snapshot to store getter (which handles firms) - used some existing getters in store.ts - updated some unit tests * - added Vitest Wrapper Factory utils - added Entity Info unit tests
Collaborator
Author
|
/gcbrun |
Collaborator
|
Temporary Url for review: https://business-edit-dev--pr-538-gnwobvg8.web.app |
4 tasks
- trying matching a different pattern for the legal name Legal API
* Add small rendering delay for Firefox, that way the review and confirm scrolls to the top of the screen. (#535) * 17347 - Add in directors for corrections for CP. (#536) * Add in directors for corrections for CP. * Fix unit tests for director change for CP. * Add in COOP. * Add in appointmentDate for co-op corrections. (#537) * Bump postcss from 8.4.30 to 8.4.31 (#533) Bumps [postcss](https://github.com/postcss/postcss) from 8.4.30 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.30...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * - app version = 4.7.5 (#541) - moved director workaround to LegalServices - moved parties workaround to LegalServices - removed workaround from Change - removed workaround from Conversion - updated unit tests * - app version = 4.7.6 (#542) - deleted obsolete "alteration-ui-enabled" FF - deleted obsolete "change-ui-enabled" FF - deleted obsolete "conversion-ui-enabled" FF - removed flag usage from Alteration.vue - removed flag usage from Change.vue - removed flag usage from Conversion.vue - removed flag usage from SpecialResolution.vue * - app version = 4.7.7 (#543) - uninstalled v-sanitize - installed vue-sanitize-directive - updated imports - added "basic" option (same as default with old package) * 17158 update fetchNameRequest (#540) * 17158 update fetchNameRequest * add debug code * add debug --wip * add debug --wip * update error handling * update NR status * update version * 18277 - Don't pre select no fee option for co-op correction. (#539) * Don't pre select no fee option for co-op correction. * Set to FAS, this way it will display $20. * Update package version. * Add in dropdown option for BEN when alterating from ULC (#545) * add in dropdown option for BEN when going from ULC * Name request check error update * Update comment and package versions * 18716 added phone number and email address to name request correction… (#547) * 18716 added phone number and email address to name request correction on file and pay * updated package json * removed debug code * 18728 - COOP Bug: Payment shows up as #3 when it should be #5 (#548) * fix csr index bug * 4.7.11 * 18735 - Fix rules showing up as being changed, when it's on paper (#549) * Fix rules being changed, when it's on paper * Fix bad code * add in extra || null * 18622 - Correction - Blank Special Resolution (#550) * 18495 - Coop Correction Changes when the Resolution is Absent (#551) * 18495 - Bug Fix - Show Resolution Section when not Correction Filing (#552) * 19069 - Special Resolution - Validation on blank association type (#553) * Bump vite from 4.3.9 to 4.5.2 (#555) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.3.9 to 4.5.2. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * major package version update --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Travis Semple <travis8814@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Séverin Beauvais <severinbeauvais@users.noreply.github.com> Co-authored-by: Kevin Zhang <54437031+kzdev420@users.noreply.github.com> Co-authored-by: Paul <144158015+PaulGarewal@users.noreply.github.com> Co-authored-by: Jia Xu <Jia.Xu@gov.bc.ca>
severinbeauvais
commented
Feb 9, 2024
Collaborator
Author
severinbeauvais
left a comment
severinbeauvais
left a comment
There was a problem hiding this comment.
How much review are you hoping I'll do of this PR?
The env changes, CD change, firebas change and version change look good. The rest is, hopefully, just the new changes we did on main branch...?
* - app version = 4.8.0 - added temporary Legal API URL in example env file - added CSP entry for temp Legal API domain in firebase config - added temporary mapping for Legal Name API URL in vaults config - fixed timer id warning - added Alternate Name IF and property to Business Information IF - updated getOriginalLegalName to return operating name from entity snapshot for firms - fixed some typing issues * - used getOriginalLegalType where possible - removed some visibilty modifiers to fix template warnings - used getOriginalBusinessInfo where possible - added many fallbacks when setting potentially undefined values to the store - fixed some type warnings - sorted some Getters and Actions - used getOriginalNrNumber where possible - added a fallback for NAICS undo - deleted some unused Getters, etc - fixed type error in NrCorrectionIF - added EditingFlagsIF to clean up state model interface - added EmptyBusinessInfo to properly reset it in the store - added some conditional chaining (since some objects can be null/undefinedl) - changed direct access of legal name from entity snapshot to store getter (which handles firms) - used some existing getters in store.ts - updated some unit tests * - added Vitest Wrapper Factory utils - added Entity Info unit tests
- trying matching a different pattern for the legal name Legal API
* Add small rendering delay for Firefox, that way the review and confirm scrolls to the top of the screen. (#535) * 17347 - Add in directors for corrections for CP. (#536) * Add in directors for corrections for CP. * Fix unit tests for director change for CP. * Add in COOP. * Add in appointmentDate for co-op corrections. (#537) * Bump postcss from 8.4.30 to 8.4.31 (#533) Bumps [postcss](https://github.com/postcss/postcss) from 8.4.30 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.30...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * - app version = 4.7.5 (#541) - moved director workaround to LegalServices - moved parties workaround to LegalServices - removed workaround from Change - removed workaround from Conversion - updated unit tests * - app version = 4.7.6 (#542) - deleted obsolete "alteration-ui-enabled" FF - deleted obsolete "change-ui-enabled" FF - deleted obsolete "conversion-ui-enabled" FF - removed flag usage from Alteration.vue - removed flag usage from Change.vue - removed flag usage from Conversion.vue - removed flag usage from SpecialResolution.vue * - app version = 4.7.7 (#543) - uninstalled v-sanitize - installed vue-sanitize-directive - updated imports - added "basic" option (same as default with old package) * 17158 update fetchNameRequest (#540) * 17158 update fetchNameRequest * add debug code * add debug --wip * add debug --wip * update error handling * update NR status * update version * 18277 - Don't pre select no fee option for co-op correction. (#539) * Don't pre select no fee option for co-op correction. * Set to FAS, this way it will display $20. * Update package version. * Add in dropdown option for BEN when alterating from ULC (#545) * add in dropdown option for BEN when going from ULC * Name request check error update * Update comment and package versions * 18716 added phone number and email address to name request correction… (#547) * 18716 added phone number and email address to name request correction on file and pay * updated package json * removed debug code * 18728 - COOP Bug: Payment shows up as #3 when it should be #5 (#548) * fix csr index bug * 4.7.11 * 18735 - Fix rules showing up as being changed, when it's on paper (#549) * Fix rules being changed, when it's on paper * Fix bad code * add in extra || null * 18622 - Correction - Blank Special Resolution (#550) * 18495 - Coop Correction Changes when the Resolution is Absent (#551) * 18495 - Bug Fix - Show Resolution Section when not Correction Filing (#552) * 19069 - Special Resolution - Validation on blank association type (#553) * Bump vite from 4.3.9 to 4.5.2 (#555) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.3.9 to 4.5.2. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * major package version update --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Travis Semple <travis8814@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Séverin Beauvais <severinbeauvais@users.noreply.github.com> Co-authored-by: Kevin Zhang <54437031+kzdev420@users.noreply.github.com> Co-authored-by: Paul <144158015+PaulGarewal@users.noreply.github.com> Co-authored-by: Jia Xu <Jia.Xu@gov.bc.ca>
18123 rebased legal name FB with main
- app version = 5.0.1 - updated NAICS API reference in vaults file Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>
* Updated to accommodate alternate name changes * updated package version * fixed comment and tests * changed to use nameTypes shared enum
severinbeauvais
commented
Apr 3, 2024
| VUE_APP_AUTH_WEB_URL="https://dev.account.bcregistry.gov.bc.ca/" | ||
| VUE_APP_BUSINESSES_URL="https://dev.account.bcregistry.gov.bc.ca/" | ||
| VUE_APP_DASHBOARD_URL="https://dev.business.bcregistry.gov.bc.ca/" | ||
| VUE_APP_DASHBOARD_URL="https://business-filings-le-dev.web.app/" |
Collaborator
Author
There was a problem hiding this comment.
Wait, what is this PR doing -- changing main branch with the contents of the feature branch?
Collaborator
Author
There was a problem hiding this comment.
Or is this PR for "later"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#15602
Description of changes: See PR #534 .
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).