Conversation
norrisng-bc
force-pushed
the
pub
branch
5 times, most recently
from
a61522e to
f23f65e
Compare
TimCsaky
force-pushed
the
pub
branch
4 times, most recently
from
f920e3d to
5663e58
Compare
Coverage Report
|
Toggle Public status of a bucket (folder) and all parent objects. Use S3 bucket policies instead of canned ACL'S Update Sync service to parse and propogate public state from S3
Full working unit tests to follow, which will be squashed into faa3d2f
TimCsaky
force-pushed
the
pub
branch
6 times, most recently
from
412f104 to
675db52
Compare
Sync Bucket and Object public status API spec updates Tidy code
TimCsaky
force-pushed
the
pub
branch
3 times, most recently
from
89c06a7 to
d30ea1a
Compare
Add `GetObjectVersion` permission to `public` bucket policies Handle sql transaction during syncBucketRecords
TimCsaky
requested review from
jatindersingh93 and
norrisng-bc
as code owners
#289 only covered non-deleted objects - this commit expands that to also include soft-deleted objects
fix sync unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SHOWCASE-3963
SHOWCASE-3964
SHOWCASE-3965
Types of changes
Checklist
Further comments