Reject PUT /object if combined bucket and file path exceeds S3 maximum#308
Merged
Reject PUT /object if combined bucket and file path exceeds S3 maximum#308
Conversation
S3 supports object keys (i.e. bucket and file paths combined, including slashes) up to 1024 bytes
Coverage Report
|
jatindersingh93
approved these changes
Jun 10, 2025
TimCsaky
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reject all
PUT /objectrequests with a combined bucket and file path exceeding 1024 bytes (i.e. bucket path + file path + filename, including all/'s in between).This is because S3 has a hard limit of 1024 bytes on object keys.
Previously, such requests were already being rejected, but with a HTTP 502 (
"detail": "Bucket communication error") instead.SHOWCASE-3792
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments
The focus of the Jira ticket was on potentially problematic characters in bucket (i.e. BCBox folder) names.
However, the only way I was able to break COMS was by creating objects with excessively long filenames that exceed the S3 max key length. This wasn't part of the original ticket, but nonetheless improves handling of potentially problematic bucket/file names.