Skip to content

Add user to existing subfolder if it exists#310

Merged
TimCsaky merged 1 commit intomasterfrom
child
Jun 27, 2025
Merged

Add user to existing subfolder if it exists#310
TimCsaky merged 1 commit intomasterfrom
child

Conversation

@TimCsaky
Copy link
Contributor

Description

ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3773?

  • when adding a subfolder (using createChildBucket endpoint), if sub-folder already exists in COMS db, instead of returning 409 collision, give current user permissions to that sub-folder.
  • when creating subfolder only require CREATE permission on the parent.

this will for example in bcbox, allow an external partner only given permission to upload into a folder, ability to create new subfolder.. on which they will also only have CREATE permission.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions
Copy link

github-actions bot commented Jun 25, 2025

Coverage Report

Totals Coverage
Statements: 55.95% ( 3051 / 5453 )
Methods: 46.05% ( 332 / 721 )
Lines: 62.55% ( 1829 / 2924 )
Branches: 49.23% ( 890 / 1808 )

@TimCsaky TimCsaky merged commit 78b71e4 into master Jun 27, 2025
13 checks passed
@norrisng-bc norrisng-bc deleted the child branch July 23, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant