Skip to content

Add child bucket: inherit all parent permissions#311

Merged
TimCsaky merged 1 commit intomasterfrom
feature/child-bucket-inherit-parent-perms
Jul 7, 2025
Merged

Add child bucket: inherit all parent permissions#311
TimCsaky merged 1 commit intomasterfrom
feature/child-bucket-inherit-parent-perms

Conversation

@norrisng-bc
Copy link
Contributor

@norrisng-bc norrisng-bc commented Jul 7, 2025

Description

When creating a child bucket, all of the parent bucket's permissions are now also applied to said child bucket.

This prevents an edge case where child buckets created by non-IDIR users cannot be deleted; the creator as a non-IDIR user won't be able to delete buckets (see #307), nor can any IDIR users that have bucket deletion permissions on the parent, as only the user creating the child bucket will have permissions assigned to it.

Not part of any existing ticket, but this issue was discovered while testing SHOWCASE-3980.

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

N/A

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

Coverage Report

Totals Coverage
Statements: 55.53% ( 3057 / 5505 )
Methods: 45.73% ( 332 / 726 )
Lines: 62.14% ( 1833 / 2950 )
Branches: 48.77% ( 892 / 1829 )

@TimCsaky TimCsaky merged commit ec1b1eb into master Jul 7, 2025
13 checks passed
@norrisng-bc norrisng-bc deleted the feature/child-bucket-inherit-parent-perms branch July 23, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants