Merged
Conversation
Coverage Report
|
norrisng-bc
force-pushed
the
feature/get-public-objects-no-auth
branch
from
63a8aaf to
a66841b
Compare
norrisng-bc
force-pushed
the
feature/get-public-objects-no-auth
branch
2 times, most recently
from
1d87f6a to
359cdaf
Compare
norrisng-bc
force-pushed
the
feature/get-public-objects-no-auth
branch
from
359cdaf to
70f3484
Compare
jatindersingh93
approved these changes
Aug 7, 2025
Contributor
|
this need a re-base |
When no-auth, forbid search params beyond the bare minimum (limit/order/page/sort is still allowed though) and redact potentially sensitive response fields (path, createdBy, updatedBy, lastSyncedDate)
norrisng-bc
force-pushed
the
feature/get-public-objects-no-auth
branch
from
70f3484 to
2aedd38
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
GET /object(search objects) endpoint can now be accessed without authentication, but with the following restrictions:bucketIdorobjectId(or both) must be specifiedbucketId,objectId,public,page,limit,sortpublicparameter must be set totruepath,createdBy,updatedBy,lastSyncedDate) are redacted in the responseNon-authenticated requests without the above will result in a HTTP 403.
This is in preparation for the upcoming "public folders" feature.
Tests to follow in separate PR. DO NOT DEPLOY TO PROD!
https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3969
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments
Tests will be added in a later PR due to time constraints.
This PR is meant to be deployed to DEV and/or TEST only, in order to provide a demo-able minimum viable product and facilitate BCBox testing.