Skip to content

Feat/generate opportunity report#522

Merged
alex-struk merged 70 commits intodevelopmentfrom
feat/generate-opportunity-report
Jul 14, 2025
Merged

Feat/generate opportunity report#522
alex-struk merged 70 commits intodevelopmentfrom
feat/generate-opportunity-report

Conversation

@alex-struk
Copy link
Collaborator

This PR closes issue: [issue #DMM-457]

Includes tests? N
Updated docs? N

Proposed changes:

  • Allows admin users to generate a complete report for all opportunity types after they are awarded by pressing the "View Complete Competition" button on the summary tab of the opportunity details page

alex-struk and others added 30 commits April 16, 2025 14:17
@alex-struk alex-struk requested a review from IanFonzie July 11, 2025 18:21
symbol_: leftPlacement(iconLinkSymbol("external-link")),
button: true,
color: "primary" as const,
onClick: () => {
Copy link
Collaborator

@IanFonzie IanFonzie Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to use the dest prop with the newTab option instead of this: https://github.com/bcgov/digital_marketplace/blob/development/src/front-end/typescript/lib/views/link.tsx#L114; same goes for the equivalent pages in SWU & TWU

@IanFonzie
Copy link
Collaborator

Looks mostly good, in addition to that one comment can you change any relative imports in this PR to be relative to the front-end, back-end or shared directories to go with the established convention.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
24.2% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@alex-struk alex-struk merged commit 2c14213 into development Jul 14, 2025
7 of 8 checks passed
@alex-struk alex-struk deleted the feat/generate-opportunity-report branch July 14, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants