Skip to content

Feat: Security audit of supplier API response objects - 950#4064

Merged
hamed-valiollahi merged 3 commits intodevelopfrom
feat/hamed-security-audit-api-responses-950
Mar 20, 2026
Merged

Feat: Security audit of supplier API response objects - 950#4064
hamed-valiollahi merged 3 commits intodevelopfrom
feat/hamed-security-audit-api-responses-950

Conversation

@hamed-valiollahi
Copy link
Collaborator

This PR audits supplier API responses to prevent unauthorized data exposure.

  • Scope GET /transfers/ to requesting user's org
  • Strip compliance unit balances from GET /organizations/{id} for non-owners
  • Add org ownership check to penalty analytics/logs endpoints
  • Add org ownership guard to PUT /organization/{org_id}/users/{user_id} for MANAGE_USERS role
  • Add org access validation to compliance report changelog endpoint
  • Change SummarySchema.extra from allow to ignore

Closes #950

@github-actions
Copy link

github-actions bot commented Mar 18, 2026

Frontend Test Results

    1 files    316 suites   3m 31s ⏱️
5 305 tests 5 287 ✅ 18 💤 0 ❌
5 321 runs  5 303 ✅ 18 💤 0 ❌

Results for commit cfbdb04.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 18, 2026

Backend Test Results

1 924 tests   1 923 ✅  15m 5s ⏱️
   45 suites      1 💤
    1 files        0 ❌

Results for commit cfbdb04.

♻️ This comment has been updated with latest results.

@hamed-valiollahi hamed-valiollahi marked this pull request as ready for review March 19, 2026 00:10
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of great security additions here ty 👍

@hamed-valiollahi
Copy link
Collaborator Author

lots of great security additions here ty 👍

Thanks Alex, appreciate the review.

@hamed-valiollahi hamed-valiollahi merged commit 02cc7f7 into develop Mar 20, 2026
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LCFS - Security Audit Review of API Response Objects

2 participants