Closed
Conversation
Collaborator
|
HER England has something similar happening, which appears to be caused by a search term being in two places. I'm going to contact them to see what they're experiencing to see if it's what's going on here, and to find out if they've already resolved this or not. |
Collaborator
|
I think we'd be better off to use the EsMappingModifier functionality for this so we don't have to override the search_term.py. I'm going to submit a separate PR for this after I'm done testing it locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the diff between
stable/8.0.6_bcgov_12377in Arches and what I have added to (and monkey-patched in) BCAP. I have NOT included the monkey-patch (which involves updatingbcap/apps.py):https://www.diffchecker.com/M3qtUzkT/
Here is
apps.py, if you want to test it out:I used:
git log -p --all -S "displayname.value" -- "**/*.py"to search through the Arches repository. I found that there existed:on August 13, 2024 which added
displaynamesearch in commit f7f3525. On May 29, 2025, it was removed during a refactor in commit b15a6d5. The line was deleted when the code was reorganized.However, this was for the search dropdown autocomplete, not the actual term filter that executes the "Contains Term" search. Our fix adds
displaynamesearch to the term filter inbcap/search_components/term_filter.py.