Skip to content

fix: #792 FOM Dashboard Gap Adjustment. #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianliuwk1019 merged 2 commits into from
Sep 23, 2025
Merged

fix: #792 FOM Dashboard Gap Adjustment. #848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afa628e
Fix CountByForestClient chart for bar gap is too wide beetween each.
ianliuwk1019 Sep 22, 2025
61c3818
Fix scroll bar issue
ianliuwk1019 Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions admin/src/app/analytics-dashboard/analytics-dashboard.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<form #alyticsForm="ngForm">
<div class="top-container" style="overflow-y: hidden;">
<div class="container">
<div class="title-container">
<div>
<form #alyticsForm="ngForm">
<!-- Page title and subtitle-->
<div>
<h1 class="text-muted mb-0">Dashboard</h1>
Expand Down Expand Up @@ -74,12 +73,12 @@ <h1 class="text-muted mb-0">Dashboard</h1>
</select>
</div>
</div>
</div>
</form>
</div>
</div>
</div>

<div class="bottom-container scroll">
<div class="bottom-container">
<!-- Public Engagement Overview -->
<div class="container pb-0" id="public-engagement-overview">
<div class="row"><p>Public Engagement Overview</p></div>
Expand Down Expand Up @@ -187,5 +186,4 @@ <h1 class="text-muted mb-0">Dashboard</h1>
></apx-chart>
</div>
</div>
</div>
</form>
</div>
6 changes: 1 addition & 5 deletions admin/src/app/analytics-dashboard/analytics-dashboard.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,8 @@ $stats-blue-1: #123B64;

// --- Bottom Container
.bottom-container {
&.scroll {
// Show vertical scrollbar only when content overflows viewport
// Show vertical scrollbar only when content overflows viewport
overflow-y: auto;
// height: 65.45vh; // TODO: need to dynamically calculate this.
height: 58.45vh; // TODO: need to dynamically calculate this.
}
}

// --- chart styling
Expand Down
2 changes: 1 addition & 1 deletion admin/src/app/analytics-dashboard/analytics-dashboard.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ export class AnalyticsDashboardComponent implements OnInit, AfterViewInit {
},
chart: {
// Horizontal bar chart dynamic height adjustment
height: Math.max(260, apiData.length * 50)
height: Math.max(260, data.length * 50)
}
});
}
Expand Down
9 changes: 0 additions & 9 deletions admin/src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,6 @@
<div class="spinner-new rotating"></div>
</div>
</app-root>

...
...
<body>
<app-root></app-root>

</body>
...
...
</body>

</html>