Merged
Conversation
…use just aws-amplify
2 tasks
2 tasks
jazzgrewal
approved these changes
Oct 28, 2025
jazzgrewal
left a comment
There was a problem hiding this comment.
Approved! Thanks for the thorough Angular v17→v19 upgrade and the cleanup across the workspace.
Summary of what I understood this PR does:
- Upgrades Angular and related libs (package.json updates across admin/public/libs)
- Migrates SCSS from @import to @use and adds namespacing for variables
- Replaces amazon-cognito-identity-js with aws-amplify/auth and updates token parsing
- Fixes a timezone‑related flaky test (project.service.spec.ts)
I had a quick look at the Angular frontend and it looks good and the app is functioning well, while communicating to the API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FOM Angular upgrade from v17 to v19.
fixed impact SCSS variables with namespace.
and adjust imapct on token parsing at auth.service.ts
project.service.spec.tsso the test does not fail in pipeline run at certain time (due to timezone).Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: