Skip to content

feat: #732 Angular 19 Upgrade#849

Merged
ianliuwk1019 merged 27 commits intomainfrom
feat/732-angular-upgrade-19
Oct 29, 2025
Merged

feat: #732 Angular 19 Upgrade#849
ianliuwk1019 merged 27 commits intomainfrom
feat/732-angular-upgrade-19

Conversation

@ianliuwk1019
Copy link
Contributor

@ianliuwk1019 ianliuwk1019 commented Oct 24, 2025

FOM Angular upgrade from v17 to v19.

  • Update package.json on Angular and some impacted libraries.
  • Upgrade on both Admin and Public sides.
  • Update all SCSS files to use newer SCSS rule: replacing @import with @use and
    fixed impact SCSS variables with namespace.
  • Update cognito.service.ts to replace 'amazon-cognito-identity-js' with use of aws-amplify/auth,
    and adjust imapct on token parsing at auth.service.ts
  • Fixed a failing test (known one since old time) at project.service.spec.ts so the test does not fail in pipeline run at certain time (due to timezone).

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@ianliuwk1019 ianliuwk1019 marked this pull request as ready for review October 25, 2025 00:55
@ianliuwk1019 ianliuwk1019 linked an issue Oct 28, 2025 that may be closed by this pull request
2 tasks
Copy link

@jazzgrewal jazzgrewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Thanks for the thorough Angular v17→v19 upgrade and the cleanup across the workspace.

Summary of what I understood this PR does:

  • Upgrades Angular and related libs (package.json updates across admin/public/libs)
  • Migrates SCSS from @import to @use and adds namespacing for variables
  • Replaces amazon-cognito-identity-js with aws-amplify/auth and updates token parsing
  • Fixes a timezone‑related flaky test (project.service.spec.ts)

I had a quick look at the Angular frontend and it looks good and the app is functioning well, while communicating to the API.

@ianliuwk1019 ianliuwk1019 merged commit d8397bb into main Oct 29, 2025
26 checks passed
@ianliuwk1019 ianliuwk1019 deleted the feat/732-angular-upgrade-19 branch October 29, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FOM Upgrades - Migrate to Angular 18 (or 19)

2 participants