Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances security by adding the --ignore-scripts flag to npm install commands in the Docker Compose configuration. This flag prevents the execution of scripts during package installation, which is the primary infection vector for the Shai Hulud malware attack.
Key changes:
- Added
--ignore-scriptsflag to all npm install commands in docker-compose.yml - Applied security protection to both the API and public service containers
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DerekRoberts
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ci --ignore-scriptsflag prevents pre-loading of npm scripts, which is the primary way Shai Hulud spreads. This should ideally be used everywhere, although there are exceptions.Re: Shai Hulud 2
Fix: via @basilv
This is a follow up to #858, since there was more to patch.
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: