Removed TypeChecked from eslint config

Fix remainder of issues

Author: kyle1morel

app/deploy-utils.ts

@@ -41,7 +41,8 @@ try {
         console.log(`${TITLE} is present and up to date`);
       }
   }
-} catch (err) {
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+} catch (error) {
   console.log(`An error occured while managing ${TITLE}`);
   process.exit(1);
 }
@@ -51,8 +52,7 @@ try {
 //
 
 /**
- * @function buildComponents
- * @description Rebuild `nr-permitting-navigator-service-frontend` library
+ * Rebuild `nr-permitting-navigator-service-frontend` library
  */
 function buildComponents() {
   if (!existsSync(`${FRONTEND_DIR}/node_modules`)) {
@@ -65,8 +65,7 @@ function buildComponents() {
 }
 
 /**
- * @function cleanComponents
- * @description Clean `nr-permitting-navigator-service-frontend` library directory
+ * Clean `nr-permitting-navigator-service-frontend` library directory
  */
 function cleanComponents() {
   console.log(`Cleaning ${TITLE}...`);
@@ -83,8 +82,7 @@ function copyDocs() {
 }
 
 /**
- * @function deployComponents
- * @description Redeploy `nr-permitting-navigator-service-frontend` library
+ * Redeploy `nr-permitting-navigator-service-frontend` library
  */
 function deployComponents() {
   console.log(`Redeploying ${TITLE}...`);
@@ -98,14 +96,12 @@ function deployComponents() {
 //
 
 /**
- * @function runSync
- * @description Execute a single shell command where `cmd` is a string
- * @param {string} cmd Shell command to run
- * @param {string} [cwd] Working directory of the command to run
+ * Execute a single shell command where `cmd` is a string
+ * @param cmd Shell command to run
+ * @param cwd Working directory of the command to run
  */
 export function runSync(cmd: string, cwd: string | undefined) {
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
-  const { spawnSync } = require('child_process');
+  const { spawnSync } = require('child_process'); // eslint-disable-line @typescript-eslint/no-require-imports
   const parts = cmd.split(/\s+/g);
   const opts = {
     cwd: cwd || undefined,
@@ -123,10 +119,9 @@ export function runSync(cmd: string, cwd: string | undefined) {
 }
 
 /**
- * @function copyFileSync
- * @description Copies `source` file to `target` file
- * @param {string} source Source file location
- * @param {string} target Target file location
+ * Copies `source` file to `target` file
+ * @param source Source file location
+ * @param  target Target file location
  */
 export function copyFileSync(source: string, target: string) {
   let targetFile = target;
@@ -142,10 +137,9 @@ export function copyFileSync(source: string, target: string) {
 }
 
 /**
- * @function copyDirRecursiveSync
- * @description Recursively copies `source` directory contents to `target` directory
- * @param {string} source Source directory location
- * @param {string} target Target directory location
+ * Recursively copies `source` directory contents to `target` directory
+ * @param source Source directory location
+ * @param  target Target directory location
  */
 export function copyDirRecursiveSync(source: string, target: string) {
   let files = [];

app/eslint.config.ts

@@ -6,15 +6,15 @@ import tseslint from 'typescript-eslint';
 
 export default tseslint.config(
   {
-    ignores: ['coverage/**', 'node_modules/**']
+    ignores: ['coverage/**', 'dist/**', 'jest.config.js', 'node_modules/**']
   },
   {
     files: ['**/*.{js,ts}'],
     extends: [
       // Extensions are order dependent - always apply Prettier last
       eslint.configs.recommended,
-      tseslint.configs.recommendedTypeChecked,
-      tseslint.configs.stylisticTypeChecked,
+      tseslint.configs.recommended,
+      tseslint.configs.stylistic,
       jsdoc.configs['flat/recommended-typescript'],
       eslintPluginPrettierRecommended,
       eslintConfigPrettier // Drops conflicting rules

app/package-lock.json

@@ -15,13 +15,13 @@
     "lint": "eslint",
     "lint:fix": "eslint --fix",
     "knex": "tsx ./node_modules/knex/bin/cli.js",
-    "migrate:down": "knex migrate:down",
+    "migrate:down": "npm run knex migrate:down",
     "migrate:latest": "npm run knex migrate:latest",
-    "migrate:list": "knex migrate:list",
-    "migrate:rollback:all": "knex migrate:rollback --all",
-    "migrate:rollback": "knex migrate:rollback",
-    "migrate:up": "knex migrate:up",
-    "migrate": "knex migrate:latest --knexfile ./sbin/knexfile.js",
+    "migrate:list": "npm run knex migrate:list",
+    "migrate:rollback:all": "npm run knex migrate:rollback --all",
+    "migrate:rollback": "npm run knex migrate:rollback",
+    "migrate:up": "npm run knex migrate:up",
+    "migrate": "npm run knex migrate:latest --knexfile ./sbin/knexfile.js",
     "peach:sync": "node sbin/peachSync.js",
     "peach:sync:local": "tsx ./peachSync.ts",
     "postbuild:all": "npm run build",
@@ -52,9 +52,9 @@
     "purge": "rimraf node_modules",
     "rebuild": "npm run clean",
     "reinstall": "npm run purge",
-    "seed:make": "knex seed:make",
-    "seed:dev": "knex seed:run --specific=dev_groups.ts",
-    "seed": "knex seed:run",
+    "seed:make": "npm run knex seed:make",
+    "seed:dev": "npm run knex seed:run --specific=dev_groups.ts",
+    "seed": "npm run knex seed:run",
     "serve": "tsx watch --include \"./config/*\" --include \"./dist/*\" ./server --clear-screen=false",
     "start": "tsx ./server",
     "test": "jest --verbose --forceExit --detectOpenHandles",
@@ -94,6 +94,7 @@
     "@types/jsonwebtoken": "^9.0.10",
     "@types/node": "^24.10.4",
     "@types/pg": "^8.16.0",
+    "@types/qs": "^6.14.0",
     "@types/supertest": "^6.0.3",
     "eslint": "9.39.1",
     "eslint-config-prettier": "10.1.8",

app/package.json

@@ -63,7 +63,6 @@ function normalizePort(val: string): string | number | boolean {
  * @param error.code Error code
  */
 function onError(error: { syscall?: string; code: string }): void {
-  // eslint-disable-next-line @typescript-eslint/only-throw-error
   if (error.syscall !== 'listen') throw error;
 
   // Handle specific listen errors with friendly messages
@@ -78,7 +77,7 @@ function onError(error: { syscall?: string; code: string }): void {
       shutdown('SIGABRT');
       break;
     default:
-      throw error; // eslint-disable-line @typescript-eslint/only-throw-error
+      throw error;
   }
 }
 

app/server.ts

@@ -8,15 +8,15 @@ import {
   getActivityContact,
   listActivityContacts,
   updateActivityContact
-} from '../services/activityContact';
-import { searchContacts } from '../services/contact';
-import { email } from '../services/email';
-import { searchEnquiries } from '../services/enquiry';
-import { verifyPrimaryChange } from '../services/helpers/activityContact';
-import { getProjectByActivityId } from '../services/project';
-import { Initiative } from '../utils/enums/application';
-import { ActivityContactRole } from '../utils/enums/projectCommon';
-import { teamAdminAddedTemplate, teamMemberAddedTemplate, teamMemberRevokedTemplate } from '../utils/templates';
+} from '../services/activityContact.ts';
+import { searchContacts } from '../services/contact.ts';
+import { email } from '../services/email.ts';
+import { searchEnquiries } from '../services/enquiry.ts';
+import { verifyPrimaryChange } from '../services/helpers/activityContact.ts';
+import { getProjectByActivityId } from '../services/project.ts';
+import { Initiative } from '../utils/enums/application.ts';
+import { ActivityContactRole } from '../utils/enums/projectCommon.ts';
+import { teamAdminAddedTemplate, teamMemberAddedTemplate, teamMemberRevokedTemplate } from '../utils/templates.ts';
 
 import type { Request, Response } from 'express';
 import type { PrismaTransactionClient } from '../db/dataConnection.ts';
@@ -46,7 +46,7 @@ const getTeamMemberEmailTemplateData = async (
       projectName
     };
 
-  const navEmail: string = config.get('server.pcns.navEmail');
+    const navEmail: string = config.get('server.pcns.navEmail');
 
     return { templateParams, navEmail };
   } catch (e) {

app/src/controllers/activityContact.ts

@@ -10,16 +10,11 @@ const excludeOperations: readonly string[] = ['create', 'createMany', 'createMan
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 function filterColumn(operation: string, args: any) {
-  // eslint-disable-next-line @typescript-eslint/no-unsafe-return
   if (excludeOperations.includes(operation)) return args;
 
-  // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
   if (!args.where) args = { ...args, where: {} };
-
-  // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
   args.where = { ...args.where, deletedAt: null };
 
-  // eslint-disable-next-line @typescript-eslint/no-unsafe-return
   return args;
 }
 
@@ -32,43 +27,36 @@ const filterDeletedTransform = Prisma.defineExtension({
   query: {
     activity: {
       $allOperations({ operation, args, query }) {
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         return query(filterColumn(operation, args));
       }
     },
     enquiry: {
       $allOperations({ operation, args, query }) {
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         return query(filterColumn(operation, args));
       }
     },
     electrification_project: {
       $allOperations({ operation, args, query }) {
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         return query(filterColumn(operation, args));
       }
     },
     housing_project: {
       $allOperations({ operation, args, query }) {
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         return query(filterColumn(operation, args));
       }
     },
     note_history: {
       $allOperations({ operation, args, query }) {
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         return query(filterColumn(operation, args));
       }
     },
     permit: {
       $allOperations({ operation, args, query }) {
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         return query(filterColumn(operation, args));
       }
     },
     permit_note: {
       $allOperations({ operation, args, query }) {
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         return query(filterColumn(operation, args));
       }
     }

app/src/db/extensions/filterDeleted.ts

@@ -35,24 +35,19 @@ function dateToTimeString(value: Date | null | undefined): string | null {
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 function normalizePermitWriteData(data: any) {
   for (const field of DATE_FIELDS) {
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
     const value = data[field];
     if (typeof value === 'string' && DATE_ONLY_REGEX.test(value)) {
-      // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
       data[field] = dateFromDateString(value);
     }
   }
 
   for (const field of TIME_FIELDS) {
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
     const value = data[field];
     if (typeof value === 'string' && TIMETZ_REGEX.test(value)) {
-      // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
       data[field] = dateFromTimeString(value);
     }
   }
 
-  // eslint-disable-next-line @typescript-eslint/no-unsafe-return
   return data;
 }
 

app/src/db/extensions/permitStatusDates.ts

@@ -171,7 +171,6 @@ export async function up(knex: Knex): Promise<void> {
           role_name: string;
         }
 
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
         const data: SqlResponse[] = await knex
           .raw(
             `SELECT
@@ -192,7 +191,6 @@ export async function up(knex: Knex): Promise<void> {
           resource.name in ('ATS', 'CONTACT', 'REPORTING', 'SSO', 'USER')`
           )
           .then((res) => {
-            // eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-member-access
             return res.rows;
           });
 
@@ -346,7 +344,6 @@ export async function down(knex: Knex): Promise<void> {
           role_name: string;
         }
 
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
         const data: SqlResponse[] = await knex
           .raw(
             `SELECT
@@ -367,7 +364,6 @@ export async function down(knex: Knex): Promise<void> {
           resource.name in ('ATS', 'CONTACT', 'REPORTING', 'SSO', 'USER')`
           )
           .then((res) => {
-            // eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-member-access
             return res.rows;
           });
 

app/src/db/migrations/20250514000000_032-api-realignment.ts

@@ -1,6 +1,3 @@
-/* eslint-disable */
-/* Too confusing */
-
 /**
  * Create CONTACT_UPDATER role (UPDATE only, no DELETE)
  * Map role to UPDATE policy on CONTACT
@@ -114,4 +111,3 @@ export async function down(knex: Knex): Promise<void> {
       )
   );
 }
-/* eslint-enable */