Skip to content

Remove isDevelopedInBc#409

Merged
kyle1morel merged 7 commits intomasterfrom
chore/remove-developed-in-bc
Jan 22, 2026
Merged

Remove isDevelopedInBc#409
kyle1morel merged 7 commits intomasterfrom
chore/remove-developed-in-bc

Conversation

@sanjaytkbabu
Copy link
Contributor

@sanjaytkbabu sanjaytkbabu commented Jan 5, 2026

Description

PADS-701

isDevelopedInBc column removed from housing_project table
FE updated to stop sending isDevelopedInBc
BE updated to remove isDevelopedInBc from types and validation
Tests fixed

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@sanjaytkbabu sanjaytkbabu requested a review from a team as a code owner January 5, 2026 23:22
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Coverage Report (Application)

Totals Coverage
Statements: 81.32% ( 3408 / 4191 )
Methods: 77.1% ( 431 / 559 )
Lines: 86.8% ( 2413 / 2780 )
Branches: 66.2% ( 564 / 852 )

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Coverage Report (Frontend)

Totals Coverage
Statements: 45.03% ( 4629 / 10280 )
Methods: 31.06% ( 523 / 1684 )
Lines: 55.48% ( 3003 / 5413 )
Branches: 34.65% ( 1103 / 3183 )

@sanjaytkbabu sanjaytkbabu force-pushed the chore/remove-developed-in-bc branch 4 times, most recently from 4974d3a to 3149c09 Compare January 8, 2026 00:24
Copy link
Collaborator

@kyle1morel kyle1morel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until #407 is pushed to prod and script is run.

@kyle1morel kyle1morel dismissed their stale review January 14, 2026 18:45

407 deployed and script run. This is safe to go in now.

@sanjaytkbabu sanjaytkbabu force-pushed the chore/remove-developed-in-bc branch from 3149c09 to f7e1a86 Compare January 16, 2026 00:02
Signed-off-by: Sanjay Babu <sanjaytkbabu@gmail.com>
Signed-off-by: Sanjay Babu <sanjaytkbabu@gmail.com>
Signed-off-by: Sanjay Babu <sanjaytkbabu@gmail.com>
Signed-off-by: Sanjay Babu <sanjaytkbabu@gmail.com>
Signed-off-by: Sanjay Babu <sanjaytkbabu@gmail.com>
Signed-off-by: Sanjay Babu <sanjaytkbabu@gmail.com>
Signed-off-by: Sanjay Babu <sanjaytkbabu@gmail.com>
@sanjaytkbabu sanjaytkbabu force-pushed the chore/remove-developed-in-bc branch from 6c8d171 to 4fb74f7 Compare January 20, 2026 16:46
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed for 'nr-permitconnect-navigator-service app'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'nr-permitconnect-navigator-service frontend'

Failed conditions
46.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@kyle1morel kyle1morel merged commit 608f8b2 into master Jan 22, 2026
20 of 21 checks passed
@kyle1morel kyle1morel deleted the chore/remove-developed-in-bc branch January 22, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants