Skip to content

Fixed Navigation Guard Issue#416

Merged
kyle1morel merged 2 commits intomasterfrom
bugfix/intake-navigation
Jan 22, 2026
Merged

Fixed Navigation Guard Issue#416
kyle1morel merged 2 commits intomasterfrom
bugfix/intake-navigation

Conversation

@sanjaytkbabu
Copy link
Contributor

@sanjaytkbabu sanjaytkbabu commented Jan 16, 2026

Description

PADS-714

Fixed navigation guard issue where callback is called twice.
Proponent UI text updated

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@sanjaytkbabu sanjaytkbabu requested a review from a team as a code owner January 16, 2026 17:22
@github-actions
Copy link

github-actions bot commented Jan 16, 2026

Coverage Report (Application)

Totals Coverage
Statements: 81.32% ( 3408 / 4191 )
Methods: 77.1% ( 431 / 559 )
Lines: 86.8% ( 2413 / 2780 )
Branches: 66.2% ( 564 / 852 )

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

Coverage Report (Frontend)

Totals Coverage
Statements: 45.02% ( 4630 / 10285 )
Methods: 31.06% ( 523 / 1684 )
Lines: 55.47% ( 3004 / 5416 )
Branches: 34.63% ( 1103 / 3185 )

@sanjaytkbabu sanjaytkbabu force-pushed the bugfix/intake-navigation branch from 807c313 to e80c53b Compare January 20, 2026 16:48
Signed-off-by: Sanjay Babu <sanjaytkbabu@gmail.com>
Signed-off-by: Sanjay Babu <sanjaytkbabu@gmail.com>
@sanjaytkbabu sanjaytkbabu force-pushed the bugfix/intake-navigation branch from e80c53b to 1639527 Compare January 22, 2026 20:02
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed for 'nr-permitconnect-navigator-service app'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'nr-permitconnect-navigator-service frontend'

Failed conditions
20.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@kyle1morel kyle1morel merged commit 0a243c4 into master Jan 22, 2026
20 of 21 checks passed
@kyle1morel kyle1morel deleted the bugfix/intake-navigation branch January 22, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants