Skip to content

Remove SCSS Variables#417

Merged
kyle1morel merged 3 commits intomasterfrom
chore/remove-scss-vars
Jan 22, 2026
Merged

Remove SCSS Variables#417
kyle1morel merged 3 commits intomasterfrom
chore/remove-scss-vars

Conversation

@sanjaytkbabu
Copy link
Contributor

@sanjaytkbabu sanjaytkbabu commented Jan 20, 2026

Description

PADS-430

Components updated with colors from the theme
SCSS main updated
SCSS variables files removed

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@sanjaytkbabu sanjaytkbabu requested a review from a team as a code owner January 20, 2026 23:35
@github-actions
Copy link

github-actions bot commented Jan 20, 2026

Coverage Report (Application)

Totals Coverage
Statements: 81.32% ( 3408 / 4191 )
Methods: 77.1% ( 431 / 559 )
Lines: 86.8% ( 2413 / 2780 )
Branches: 66.2% ( 564 / 852 )

@sanjaytkbabu sanjaytkbabu force-pushed the chore/remove-scss-vars branch from 877f65c to d7306aa Compare January 20, 2026 23:38
@github-actions
Copy link

github-actions bot commented Jan 20, 2026

Coverage Report (Frontend)

Totals Coverage
Statements: 45.18% ( 4647 / 10285 )
Methods: 31.18% ( 525 / 1684 )
Lines: 55.69% ( 3016 / 5416 )
Branches: 34.73% ( 1106 / 3185 )

Signed-off-by: Sanjay Babu <sanjaytkbabu@gmail.com>
Signed-off-by: Sanjay Babu <sanjaytkbabu@gmail.com>
Signed-off-by: Sanjay Babu <sanjaytkbabu@gmail.com>
@sanjaytkbabu sanjaytkbabu force-pushed the chore/remove-scss-vars branch from bda8f14 to a1b3df3 Compare January 22, 2026 20:08
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed for 'nr-permitconnect-navigator-service app'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed for 'nr-permitconnect-navigator-service frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kyle1morel kyle1morel merged commit 4abb8e5 into master Jan 22, 2026
21 checks passed
@kyle1morel kyle1morel deleted the chore/remove-scss-vars branch January 22, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants