Conversation
…sis workflow Remove the conditional FLYWAY_ENVIRONMENT workflow env from Oracle and Postgres test jobs. Update mvnw invocations: drop -Dflyway-environment for the Oracle job, and hardcode -Dflyway-environment=dev for the Postgres job. This simplifies the CI config and removes the previous github.event_name-based env expression.
Abradat
requested review from
DerekRoberts,
craigyu and
paulushcgcj
as code owners
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions Analysis workflow to simplify how backend test jobs choose their Flyway migration environment, addressing failures on push events to main (issue #1182).
Changes:
- Removed the
FLYWAY_ENVIRONMENTjob-level env var from the backend Oracle and Postgres test jobs. - Updated Maven invocation for Postgres tests to always run with
-Dflyway-environment=dev. - Removed
-Dflyway-environmententirely from the Oracle test job Maven invocation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Update backend/README.md to remove guidance that sets the FLYWAY_ENVIRONMENT for Oracle. The Oracle example no longer exports FLYWAY_ENVIRONMENT=dev, and the Maven test command for Oracle drops -Dflyway-environment=dev. Added notes explaining that setting the flyway environment (env var or property) is unnecessary for Oracle-primary runs/tests since the intent is to run against the production-deployed backend. Minor formatting/spacing adjustments included.
craigyu
approved these changes
Feb 11, 2026
Abradat
deleted the
bugfix/1182-analysis-workflows-backend-postgres-tests-job-fails-on-push-events-to-the-main-branch
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the workflow configuration in
.github/workflows/analysis.ymlto simplify environment variable handling for backend tests. The most important changes are grouped below by theme.Workflow environment simplification:
FLYWAY_ENVIRONMENTenvironment variable from both the Oracle and Postgres test jobs, eliminating conditional logic based on the event type. [1] [2]Build command updates:
-Dflyway-environmentproperty from the Maven command, so it no longer passes this environment variable.-Dflyway-environment=devinstead of referencing the removed environment variable.Fixes #1182
Type of change
How Has This Been Tested?
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: