fix: add activity related class for reflection#1215
Merged
Conversation
craigyu
requested review from
Abradat,
carolinemwood and
paulushcgcj
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses native-image reflection issues that cause the activity search query to fail by registering newly introduced activity-search DTOs for Spring AOT reflection binding.
Changes:
- Register
ActivitySearchFiltersDtofor SpEL-based query parameter access under native image. - Register
ActivitySearchResponseDtofor JSON (de)serialization under native image.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...d/src/main/java/ca/bc/gov/restapi/results/common/configuration/SilvaGlobalConfiguration.java
Outdated
Show resolved
Hide resolved
…bcgov/nr-silva into fix/reflection-for-native-image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the problem where activity search query fails due to native image issues with new DTOs.
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: