Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 7, 2025

Description

Upgrades terraform-aws-modules/rds-aurora/aws from v9.16.1 to v10.0.0 to resolve workflow failures caused by breaking changes in the module API.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes

Module version

  • Updated to 10.0.0

Variable migrations per v10 breaking changes:

  • instance_classcluster_instance_class
  • master_passwordmaster_password_wo with master_password_wo_version = 1 (write-only attribute)
  • auto_minor_version_upgrade moved from module-level to per-instance configuration
# Before (v9)
module "aurora_postgresql_v2" {
  version                    = "9.16.1"
  instance_class             = "db.serverless"
  master_password            = random_password.db_master_password.result
  auto_minor_version_upgrade = true
  instances = { one = {}, two = {} }
}

# After (v10)
module "aurora_postgresql_v2" {
  version                    = "10.0.0"
  cluster_instance_class     = "db.serverless"
  master_password_wo         = random_password.db_master_password.result
  master_password_wo_version = 1
  instances = {
    one = { auto_minor_version_upgrade = true }
    two = { auto_minor_version_upgrade = true }
  }
}

How Has This Been Tested?

  • Code review completed
  • CodeQL security scan passed

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have already been accepted and merged

Further comments

Migration follows the official v10 upgrade guide. Terraform v1.11+ and AWS provider v6.18+ are required by v10; the workflow already uses Terraform v1.12.2.

Original prompt

The workflow failed due to a breaking change after upgrading from terraform-aws-modules/rds-aurora/aws v9 to v10. The error reported is: "An argument named 'instance_class' is not expected here." This is due to v10 renaming the variable as 'cluster_instance_class' and other migration changes.

Steps to resolve:

  • Update references in Terraform code (including terragrunt/prod/infra and other Aurora-related configs) where instance_class is set; replace with cluster_instance_class as per v10 migration guide.
  • Review other module variable changes (password variable, security group rules, etc.) according to the official migration guide: https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/releases/tag/v10.0.0
  • Validate the workflow runs, i.e., .github/workflows/pr-open.yml continues to function correctly after upgrade.

Migration reference:

Make all required changes to ensure compatibility with v10 and resolve the workflow failure.

This pull request was created as a result of the following prompt from Copilot chat.

The workflow failed due to a breaking change after upgrading from terraform-aws-modules/rds-aurora/aws v9 to v10. The error reported is: "An argument named 'instance_class' is not expected here." This is due to v10 renaming the variable as 'cluster_instance_class' and other migration changes.

Steps to resolve:

  • Update references in Terraform code (including terragrunt/prod/infra and other Aurora-related configs) where instance_class is set; replace with cluster_instance_class as per v10 migration guide.
  • Review other module variable changes (password variable, security group rules, etc.) according to the official migration guide: https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/releases/tag/v10.0.0
  • Validate the workflow runs, i.e., .github/workflows/pr-open.yml continues to function correctly after upgrade.

Migration reference:

Make all required changes to ensure compatibility with v10 and resolve the workflow failure.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Fix breaking change after upgrading terraform-aws-modules/rds-aurora Migrate Terraform AWS RDS Aurora module from v9 to v10 Dec 7, 2025
Copilot AI requested a review from DerekRoberts December 7, 2025 17:17
@DerekRoberts DerekRoberts marked this pull request as ready for review December 7, 2025 17:23
Copilot AI review requested due to automatic review settings December 7, 2025 17:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the Terraform AWS RDS Aurora module from version 9.16.1 to 10.0.0 to resolve workflow failures caused by breaking changes in the module's API. The migration correctly implements all required variable name changes and configuration restructuring per the official v10 upgrade guide.

Key changes:

  • Module version updated from 9.16.1 to 10.0.0
  • Variable migrations: instance_classcluster_instance_class, master_passwordmaster_password_wo with version tracking
  • Configuration restructuring: auto_minor_version_upgrade moved from module-level to per-instance settings for all instances (both HA and non-HA configurations)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@DerekRoberts DerekRoberts changed the title Migrate Terraform AWS RDS Aurora module from v9 to v10 chore: Migrate Terraform AWS RDS Aurora module from v9 to v10 Dec 7, 2025
@DerekRoberts DerekRoberts merged commit 94bab2b into main Dec 7, 2025
31 of 32 checks passed
@DerekRoberts DerekRoberts deleted the copilot/update-terraform-aurora-variables branch December 7, 2025 17:27
@github-project-automation github-project-automation bot moved this from New to Done in DevOps (NR) Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants