Merged
Conversation
d82b24a to
267d558
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Removes pinned digests from Docker Compose service images to simplify tag updates and maintenance.
- Dropped
@sha256digests for all service images (database, migrations, backend). - Simplified tags to major versions (e.g.,
postgres:15,flyway/flyway:9-alpine,python:3.13). - Retained the stability comment for
python:3.11-slim-busterafter removing its digest.
Files not reviewed (5)
- backend-go/Dockerfile: Language not supported
- backend-go/db/Dockerfile: Language not supported
- backend-java/Dockerfile: Language not supported
- backend-py/Dockerfile: Language not supported
- backend-py/db/Dockerfile: Language not supported
Comments suppressed due to low confidence (1)
docker-compose.yml:40
- [nitpick] Removing the digest pinning can lead to non-reproducible builds. Consider keeping image digests or documenting the trade-offs to ensure predictable deployments.
image: postgres:15
Contributor
There was a problem hiding this comment.
Pull Request Overview
This chore removes docker digests from the image references in the docker-compose file, switching to tag-based versioning.
- Removed image digests for the postgres, flyway, and python images
- Simplified image references to use tags only
Files not reviewed (5)
- backend-go/Dockerfile: Language not supported
- backend-go/db/Dockerfile: Language not supported
- backend-java/Dockerfile: Language not supported
- backend-py/Dockerfile: Language not supported
- backend-py/db/Dockerfile: Language not supported
Comments suppressed due to low confidence (5)
docker-compose.yml:40
- Dropping the image digest here means that the postgres image is now based solely on the tag, which might lead to non-deterministic builds if the tag is updated. Consider whether this trade-off aligns with your deployment strategy.
image: postgres:15
docker-compose.yml:50
- Using only the tag for the flyway image can result in pulling unintended updates; ensure that the deployment process accounts for potential version drift.
image: flyway/flyway:9-alpine
docker-compose.yml:63
- Dropping the digest here too means that the flyway image for the python migrations relies solely on the tag. Reconfirm that image updates are managed appropriately in your CI/CD pipeline.
image: flyway/flyway:9-alpine
docker-compose.yml:106
- Switching to tag-only reference for the python image may lead to non-reproducible builds if the tag changes; verify that version consistency is ensured elsewhere in your process.
image: python:3.13
docker-compose.yml:122
- As with the other python image reference, omitting the digest here means reliance on the tag. Confirm that appropriate measures are in place to avoid unexpected image updates.
image: python:3.13
5eab7e4 to
f33d4e6
Compare
f33d4e6 to
00fe8f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: