Skip to content

chore: drop Go backend from tests#335

Merged
mishraomp merged 1 commit intomainfrom
chore/dropGoII
May 29, 2025
Merged

chore: drop Go backend from tests#335
mishraomp merged 1 commit intomainfrom
chore/dropGoII

Conversation

@DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented May 29, 2025


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copilot AI review requested due to automatic review settings May 29, 2025 02:46
@DerekRoberts DerekRoberts requested a review from mishraomp as a code owner May 29, 2025 02:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes references to the Go backend from our integration test suites and CI/CD pipelines. The changes include removing the integration test file for the fiber backend (which appears to be associated with the Go backend), eliminating the Go-related markdown link in the PR validation workflow, and updating the merge workflow matrix by removing the "fiber" entry that points to a Go backend.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
integration-tests/src/test_suites/it.backend.fiber.json Removed the integration tests targeting the Go backend (noting the confusing "fiber" naming)
.github/workflows/pr-validate.yml Removed the markdown link for the Go backend
.github/workflows/merge.yml Updated job matrix by removing the "fiber" entry referring to the Go backend
Comments suppressed due to low confidence (2)

integration-tests/src/test_suites/it.backend.fiber.json:1

  • [nitpick] The file name and its content indicate 'fiber' while the PR title and context mention dropping the Go backend. Confirm that the 'fiber' naming is appropriate or if it should be clarified to reflect the intended backend being removed.
"api_name": "fiber"

.github/workflows/merge.yml:55

  • [nitpick] The matrix originally includes 'fiber' which is removed in this PR, yet the associated baseUrl references a Go backend. Consider reviewing the naming for clarity so that the removed entry clearly represents the dropped Go backend.
name: [quarkus, fiber, fastapi]

@DerekRoberts DerekRoberts self-assigned this May 29, 2025
@DerekRoberts DerekRoberts moved this from New to Active in DevOps (NR) May 29, 2025
Copy link
Collaborator

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting leaner, wohoo

@github-project-automation github-project-automation bot moved this from Active to Waiting in DevOps (NR) May 29, 2025
@mishraomp mishraomp merged commit 8db6c19 into main May 29, 2025
18 checks passed
@mishraomp mishraomp deleted the chore/dropGoII branch May 29, 2025 02:49
@github-project-automation github-project-automation bot moved this from Waiting to Done in DevOps (NR) May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants