Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes references to the Go backend from our integration test suites and CI/CD pipelines. The changes include removing the integration test file for the fiber backend (which appears to be associated with the Go backend), eliminating the Go-related markdown link in the PR validation workflow, and updating the merge workflow matrix by removing the "fiber" entry that points to a Go backend.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| integration-tests/src/test_suites/it.backend.fiber.json | Removed the integration tests targeting the Go backend (noting the confusing "fiber" naming) |
| .github/workflows/pr-validate.yml | Removed the markdown link for the Go backend |
| .github/workflows/merge.yml | Updated job matrix by removing the "fiber" entry referring to the Go backend |
Comments suppressed due to low confidence (2)
integration-tests/src/test_suites/it.backend.fiber.json:1
- [nitpick] The file name and its content indicate 'fiber' while the PR title and context mention dropping the Go backend. Confirm that the 'fiber' naming is appropriate or if it should be clarified to reflect the intended backend being removed.
"api_name": "fiber"
.github/workflows/merge.yml:55
- [nitpick] The matrix originally includes 'fiber' which is removed in this PR, yet the associated baseUrl references a Go backend. Consider reviewing the naming for clarity so that the removed entry clearly represents the dropped Go backend.
name: [quarkus, fiber, fastapi]
mishraomp
approved these changes
May 29, 2025
Collaborator
mishraomp
left a comment
There was a problem hiding this comment.
getting leaner, wohoo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: