Skip to content

chore: Potential fix for code scanning alert no. 34: Server-side request forgery #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DerekRoberts merged 4 commits into from
Dec 8, 2025
Merged

chore: Potential fix for code scanning alert no. 34: Server-side request forgery #393

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2886534
chore: Potential fix for code scanning alert no. 34: Server-side requ…
DerekRoberts Dec 7, 2025
9290300
Update backend-java/.mvn/wrapper/MavenWrapperDownloader.java
DerekRoberts Dec 7, 2025
34d5519
chore: refactor URL validation into dedicated method (#397)
Copilot Dec 8, 2025
e43b0de
Merge main into alert-autofix-34: combine SSRF and path traversal fixes
DerekRoberts Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions backend-java/.mvn/wrapper/MavenWrapperDownloader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,16 @@ public static void main( String[] args )
{
log( " - Downloader started" );
final URL wrapperUrl = new URL( args[0] );
// Restrict downloads to well-known Maven repository hosts
final String allowedHost = "repo.maven.apache.org";
final String allowedHost2 = "repo1.maven.org";
if (!"https".equalsIgnoreCase(wrapperUrl.getProtocol()) ||
!(allowedHost.equalsIgnoreCase(wrapperUrl.getHost()) ||
allowedHost2.equalsIgnoreCase(wrapperUrl.getHost())))
{
System.err.println(" - ERROR: Only downloads from [" + allowedHost + "] or [" + allowedHost2 + "] over HTTPS are allowed.");
System.exit(1);
}
final String jarPath = args[1].replace( "..", "" ); // Sanitize path
final Path wrapperJarPath = Paths.get( jarPath ).toAbsolutePath().normalize();
downloadFileFromURL( wrapperUrl, wrapperJarPath );
Expand Down
Loading