Skip to content

chore(ci): scheduled job fix#2322

Merged
DerekRoberts merged 7 commits intomainfrom
chore/ciScheduledJobFix
Apr 7, 2025
Merged

chore(ci): scheduled job fix#2322
DerekRoberts merged 7 commits intomainfrom
chore/ciScheduledJobFix

Conversation

@DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Apr 7, 2025

Fix scheduled job while trying not to repeat too much code. (DRY = don't repeat yourself)


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copilot AI review requested due to automatic review settings April 7, 2025 17:03
@DerekRoberts DerekRoberts self-assigned this Apr 7, 2025
@DerekRoberts DerekRoberts moved this from New to Active in DevOps (NR) Apr 7, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.github/workflows/scheduled.yml:73

  • The 'frontend' configuration does not define a 'path' property, yet it is referenced in the target URL computation. Consider adding a 'path' property for the frontend job to prevent undefined behavior.
- name: frontend

.github/workflows/scheduled.yml:3

  • Switching the trigger from the scheduled event to pull_request will change the intended run behavior of the job. Verify that this change is deliberate and that the job should no longer run on a schedule.
on: [pull_request]

@DerekRoberts DerekRoberts merged commit 2f1d739 into main Apr 7, 2025
12 of 13 checks passed
@DerekRoberts DerekRoberts deleted the chore/ciScheduledJobFix branch April 7, 2025 17:24
@github-project-automation github-project-automation bot moved this from Active to Done in DevOps (NR) Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants