Skip to content

docs: Update README.md#2343

Merged
DerekRoberts merged 2 commits intomainfrom
MonicaG-patch-1-1
Apr 24, 2025
Merged

docs: Update README.md#2343
DerekRoberts merged 2 commits intomainfrom
MonicaG-patch-1-1

Conversation

@MonicaG
Copy link
Contributor

@MonicaG MonicaG commented Apr 24, 2025

Description

Removed the link to just-ask.developer.gov.bc.ca. Replaced with link to instructions on how to join the bcgov organization.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

No, it was just a change to the documentation (the README.md file).

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Signed-off-by: Monica Granbois <MonicaG@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 24, 2025 20:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the README.md file to replace the outdated link for joining the BCGov GitHub organization with a link to the current instructions.

  • Updated the documentation link in the requirements list
  • Removed reference to the deprecated Just Ask page
Comments suppressed due to low confidence (1)

README.md:72

  • [nitpick] Consider using more descriptive link text to clearly indicate the purpose of the link, such as 'Join the BCGov organization using these instructions'.
* Join by [following these instructions](https://developer.gov.bc.ca/docs/default/component/bc-developer-guide/use-github-in-bcgov/bc-government-organizations-in-github/#directions-to-sign-up-and-link-your-account-for-bcgov).

@MonicaG MonicaG changed the title Update README.md docs: Update README.md Apr 24, 2025
Signed-off-by: Monica Granbois <MonicaG@users.noreply.github.com>
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the correction! :)

@github-project-automation github-project-automation bot moved this from New to Waiting in DevOps (NR) Apr 24, 2025
@DerekRoberts DerekRoberts merged commit 7cf4465 into main Apr 24, 2025
18 checks passed
@DerekRoberts DerekRoberts deleted the MonicaG-patch-1-1 branch April 24, 2025 22:40
@github-project-automation github-project-automation bot moved this from Waiting to Done in DevOps (NR) Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants