Skip to content

Conversation

@WalterMoar
Copy link
Contributor

Description

The liveness probe was hard coded to use port 3000. This causes problems when .Values.backend.service.targetPort is used for backends that use a different port. This way all probes will use the same port.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

  • New unit tests
  • New integrated tests
  • New component tests
  • New end-to-end tests
  • New user flow tests
  • No new tests are required
  • Manual tests (description below)
  • Updated existing tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

The liveness probe was hard coded to use port 3000. This causes problems when .Values.backend.service.targetPort is used for backends that use a different port. This way all probes will use the same port.

Signed-off-by: Walter Moar <[email protected]>
@github-project-automation github-project-automation bot moved this from New to Waiting in DevOps (NR) Jan 8, 2026
@DerekRoberts
Copy link
Member

@WalterMoar Thanks for the fix! 😀

@DerekRoberts DerekRoberts merged commit 0c5dcee into bcgov:main Jan 8, 2026
11 of 16 checks passed
@github-project-automation github-project-automation bot moved this from Waiting to Done in DevOps (NR) Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants