chore: add security-sensitive file patterns to .gitignore #2576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add patterns to prevent accidental commits of credential files: - Tomcat/Java config files (context.xml, server.xml, etc.) - Java keystores and truststores (*.jks, *.jceks, etc.) - Spring Boot application properties with secrets - Common credential files (credentials.json, secrets.json, etc.) - PKCS12 keystores (*.p12, *.pfx) This helps prevent password leaks in future Java backends that teams may add to projects using this template.
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds patterns to
.gitignoreto prevent accidental commits of credential files, particularly for Java/Tomcat backends that teams may add to projects using this template.Changes
Added 28 new patterns to prevent credential leaks:
context.xml,server.xml,tomcat-users.xml,web.xml*.jks,*.jceks,keystore.*,truststore.*application-local.properties,application-prod.properties,application-*.yml, etc.credentials.json,secrets.json,secrets.yml, etc.*.p12,*.pfxMotivation
Prevents password leaks in future Java backends (similar to
context.xmlleaks that have occurred). This is a proactive security measure for the template repository.Testing
.gitignoreconventions (using**/for recursive matching)*.key,*.pem,*.pub)Checklist
.gitignorepatterns and conventionsThanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: