24648- Enable new role support for contact_centre_staff#3198
24648- Enable new role support for contact_centre_staff#3198rodrigo-barraza merged 18 commits intobcgov:mainfrom
Conversation
|
pushing out a build, just putting do not merge for a couple |
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-3198-au1sskp7.web.app |
|
@rodrigo-barraza can't access the staff dashboard with just the contact_centre_staff group on its own
I did some quick and loose updates on this PR https://github.com/bcgov/sbc-auth/pull/3182/files#diff-d93db5d449e4fa9564fbab4824387879235c21d4a5db11a7e19b69aedd2878fb They may not be totally correct as I was just trying to get a version of the UI that we could verify the API permissions changes with. But you probably need some updates for the router. |
Added support for users with contact_centre_staff as their role, but without admin. |
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-3198-au1sskp7.web.app |
|
Probably need to hide involuntary dissolution tile as per parent ticket, maybe document service, you would need to check with Patty and Ethan. Columns not showing data Check box should be read only as well
When I click transactions it just takes me to account info |
Spoke with Patty, we decided that involuntary dissolution and document record service should both be hidden. |
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-3198-au1sskp7.web.app |
|
On the main dashboard this probably needs to be hidden
Also, I still don't seem to be able to access Transactions |
| ] | ||
|
|
||
| public mounted () { | ||
| this.canDoActions = !this.currentUser?.roles?.includes(Role.ContactCentreStaff) |
There was a problem hiding this comment.
Would it be better to just abstract this a bit since we are re-using v-can and the common utils Permissions?
We can add a permission there and not need to add the role check here specifically?
^ The above applies to other places as well
There was a problem hiding this comment.
Fixed transactions, and moved logic to permissions and v-can:
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-3198-au1sskp7.web.app |
|
@rodrigo-barraza |
|
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-3198-au1sskp7.web.app |
4 participants
Issue #:
bcgov/entity#24648
Description of changes:
Hiding various buttons, and disabling some actions for users with the role contact_centre_staff.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).