14853 - Fixes & Remove redundant code#3589
Merged
Jxio merged 2 commits intobcgov:mainfrom Jan 29, 2026
Merged
Conversation
Jxio
commented
Jan 29, 2026
|
seeker25
reviewed
Jan 29, 2026
| if task is None or ( | ||
| task.relationship_status != TaskRelationshipStatus.ACTIVE.value | ||
| and task.action == TaskAction.PRODUCT_REVIEW.value | ||
| and task.action in (TaskAction.PRODUCT_REVIEW.value, TaskAction.NEW_PRODUCT_FEE_REVIEW.value) |
Collaborator
There was a problem hiding this comment.
this doesn't look redundant, looks like a bug fix ;)
Collaborator
Author
There was a problem hiding this comment.
yeah I just realized if I add it here then I don't need pay service
seeker25
approved these changes
Jan 29, 2026
seeker25
changed the title
Jxio
added a commit
to Jxio/sbc-auth
that referenced
this pull request
Feb 12, 2026
This reverts commit d138132.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#14853
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).