Skip to content

Small tweak for Account-Id or business identifier undefined #3605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seeker25 merged 3 commits into from
Feb 10, 2026
Merged

Small tweak for Account-Id or business identifier undefined #3605

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d16f91e
small tweak for Account-Id undefined
seeker25 Feb 10, 2026
54562ea
add forbidden
seeker25 Feb 10, 2026
781fefa
fix unit test
seeker25 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions auth-api/src/auth_api/services/authorization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ def check_auth(**kwargs):
else:
business_identifier = kwargs.get("business_identifier", None)
org_identifier = kwargs.get("org_id", None) or user_from_context.account_id
auth = None
if business_identifier:
auth = Authorization.get_user_authorizations_for_entity(business_identifier)
Copy link
Collaborator Author

@seeker25 seeker25 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

returns {}

elif org_identifier:
Expand Down
4 changes: 2 additions & 2 deletions auth-api/tests/unit/services/test_authorization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,8 +405,8 @@ def test_check_auth_system_path(
"test_desc,test_expect,additional_kwargs,is_org_member,is_entity_affiliated",
[
(
"Test UnboundLocalError (403) when no role checks provided in kwargs.",
pytest.raises(UnboundLocalError),
"Test (403) when no role checks provided in kwargs.",
pytest.raises(Forbidden),
{},
False,
False,
Expand Down
Loading