Merged
Conversation
…zed user retrieval
…as the lighter-weight content payload after insert
Fosol
added
enhancement
Fosol
reviewed
Sep 22, 2025
reduce latency for adding content in report
Fosol
reviewed
Sep 25, 2025
Mmi 3243 update
…mi-3243-update
Mmi 3243 update
…mi-3243-update
Mmi 3243 update
…mi-3243-update
Mmi 3243 update
…mi-3243-update
Mmi 3243 update
Fosol
reviewed
Oct 2, 2025
|
|
||
| const convertedContent = toInstanceContent(content, instance.id, sectionName, 0); | ||
| await addContentToReport(currentReport.id, convertedContent); | ||
| const payload = toInstanceContentPayload(content, 0, sectionName, 0); |
Collaborator
There was a problem hiding this comment.
The main thing I'm noticing here is there is no logic to handle the different scenarios/states the the report can be in. Has the logic been moved to the API?
Collaborator
Author
There was a problem hiding this comment.
Yes, the logic is moved to the FastAddContentToReportAsync in the ReportController now.
Fosol
approved these changes
Oct 6, 2025
Fosol
pushed a commit
that referenced
this pull request
Oct 6, 2025
* Add FindByIdMinimal method to IUserService and UserService for optimized user retrieval * use FindByIdMinimal to speed up * improvement for adding content in existing reports * simplify the content metadata and add functions that the subscriber has the lighter-weight content payload after insert * remove checks on subscribers allowing to add content to someone else report * restore changes for checking reports is public or not * update tno-core package version * reduce latency for adding content in report * fix lint errors and build errors * add missing files * update * update * add missing files * update addtoreportmenu to load minimal data * update npm package version * fix build error * fix infinite regenerate report bug and others * fixed bug * fix the bug that causes the reports not showing up * fix the loading report bug * update * fix the duplicated id * fix build error --------- Co-authored-by: Jacob Wang <jacob.wang@gov.bc.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.