Conversation
| * Ensures report-level and section-level settings include explicit boolean values for | ||
| * removeDuplicateTitles3Days and applies dedupe logic before persisting. | ||
| */ | ||
| export const sanitizeReport = (report: IReportForm): IReportForm => { |
There was a problem hiding this comment.
Does this just remove duplicate stories with same title? If so, is this essentially the same logic added to the ReportService?
There was a problem hiding this comment.
I added the client-size logic so that when the toggle is on, duplicates will be removed from the report. The logic in ReportService is not called immediately when the toggle is turned on.
There was a problem hiding this comment.
I think that will make a better user experience.
|
I've merged my latest fixes and deployed to production. You'll regrettably need to resolve conflicts in your PR. Sorry! |
Fosol
added
enhancement
… not send to subscribers again when the flag is on
There was a problem hiding this comment.
I don't have any suggestions atm, but I'm noting a pattern of increased complexity to the generation of reports. It'll get more difficult to add functionality or change functionality going forward. Offhand I don't know how we can clean things up so that it gets easier.
* added remove duplicate titles for the last 3 days * update npm package * fix editor bug * fix editor build error * add missing changes * remove files and added missing files * update logic if content with the same title already sent out, it will not send to subscribers again when the flag is on * update
* added remove duplicate titles for the last 3 days * update npm package * fix editor bug * fix editor build error * add missing changes * remove files and added missing files * update logic if content with the same title already sent out, it will not send to subscribers again when the flag is on * update
2 participants
No description provided.