Skip to content

Conversation

@PatStLouis
Copy link
Contributor

No description provided.

Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
@PatStLouis PatStLouis marked this pull request as ready for review December 15, 2025 23:08
@github-actions
Copy link

@PatStLouis PatStLouis marked this pull request as draft December 15, 2025 23:18
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
@PatStLouis PatStLouis marked this pull request as ready for review January 7, 2026 14:52
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
@PatStLouis
Copy link
Contributor Author

@esune @loneil the pr is ready for review

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the askar-anoncreds endpoint support and unifies the tenant-ui to support both WebVH and Indy identifiers within the same interface. The changes enable askar-anoncreds wallets to work with both Indy-based and WebVH-based credentials simultaneously.

Key changes include:

  • Unified DID display showing both Indy public DIDs and WebVH DIDs in a single table
  • Enhanced schema and credential definition storage to support both Indy and AnonCreds formats
  • Improved revocation handling with automatic endpoint detection based on credential format
  • Added validation for both Indy and AnonCreds schema/credential definition ID formats

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 20 comments.

Show a summary per file
File Description
services/tenant-ui/frontend/src/views/Identifiers.vue Unified DID display to show both Indy and WebVH identifiers with custom sorting to keep public Indy DID at top
services/tenant-ui/frontend/src/store/tenantStore.ts Updated isIssuer check to allow issuing when connected to either Indy OR WebVH
services/tenant-ui/frontend/src/store/issuerStore.ts Enhanced revocation to auto-detect credential format and use appropriate AnonCreds or Indy endpoint
services/tenant-ui/frontend/src/store/governanceStore.ts Added functions to list and merge schemas/cred defs from both Indy and AnonCreds endpoints with manual storage fallback
services/tenant-ui/frontend/src/store/index.ts Exported useCommonStore for consistent imports
services/tenant-ui/frontend/src/store/utils/fetchItem.ts Added URL encoding for IDs to handle special characters like colons and slashes
services/tenant-ui/frontend/src/components/verifier/createPresentationRequest/CreateRequestForm.vue Auto-determine presentation request filter type based on wallet type
services/tenant-ui/frontend/src/components/layout/Header.vue Updated import path for useCommonStore
services/tenant-ui/frontend/src/components/issuance/schemas/Schemas.vue Simplified to use unified storage endpoints for both wallet types
services/tenant-ui/frontend/src/components/issuance/schemas/CreateSchemaForm.vue Enhanced issuer dropdown to show both Indy and WebVH DIDs
services/tenant-ui/frontend/src/components/issuance/schemas/CreateSchema.vue Updated to load wallet DIDs instead of WebVH config
services/tenant-ui/frontend/src/components/issuance/credentials/RevokeCredentialForm.vue Added credential format detection to use correct revocation endpoint
services/tenant-ui/frontend/src/components/issuance/credentials/OfferCredentialForm.vue Enhanced schema lookup with fallback to AnonCreds endpoint and improved error handling
services/tenant-ui/frontend/src/components/issuance/credentials/OfferCredential.vue Simplified to use unified storage endpoints
services/tenant-ui/frontend/src/components/issuance/credentials/EnterCredentialValues.vue Added schema validation and support for both Indy and AnonCreds attribute formats
services/tenant-ui/frontend/src/components/issuance/credentialDefinitions/CredentialDefinitions.vue Simplified to use unified storage endpoints for both wallet types
services/tenant-ui/frontend/src/components/issuance/credentialDefinitions/CreateCredentialDefinition.vue Updated to load wallet DIDs instead of WebVH config
services/tenant-ui/frontend/src/plugins/i18n/locales/en.json Added "filterType" translation keys
services/tenant-ui/frontend/src/helpers/constants.ts Added URL encoding to storage item paths and new AnonCreds revocation endpoint
plugins/traction_innkeeper/traction_innkeeper/v1_0/schema_storage/schema_storage_service.py Enhanced to support both Indy ledger and AnonCreds registry schema retrieval with retry logic
plugins/traction_innkeeper/traction_innkeeper/v1_0/schema_storage/models.py Updated validation to accept both Indy and AnonCreds schema ID formats
plugins/traction_innkeeper/traction_innkeeper/v1_0/creddef_storage/routes.py Added POST endpoint for manually adding credential definitions to storage
plugins/traction_innkeeper/traction_innkeeper/v1_0/creddef_storage/models.py Updated validation to accept both Indy and AnonCreds credential definition ID formats
plugins/traction_innkeeper/traction_innkeeper/v1_0/creddef_storage/creddef_storage_service.py Enhanced to support both Indy ledger and AnonCreds registry credential definition retrieval
plugins/traction_innkeeper/traction_innkeeper/v1_0/tests/test_creddef_storage_routes.py Updated test to expect 4 routes instead of 3 after adding POST endpoint

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@PatStLouis PatStLouis force-pushed the update-tenant-ui-anoncreds-endpoints branch from cc5ae75 to 38c779a Compare January 7, 2026 17:27
PatStLouis and others added 8 commits January 7, 2026 12:28
…eateSchemaForm.vue

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
…s/RevokeCredentialForm.vue

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
…eateSchemaForm.vue

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
…s/RevokeCredentialForm.vue

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
…hemas.vue

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
…s/RevokeCredentialForm.vue

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
PatStLouis and others added 5 commits January 7, 2026 12:28
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
@PatStLouis PatStLouis force-pushed the update-tenant-ui-anoncreds-endpoints branch from 38c779a to a18fa0c Compare January 7, 2026 17:29
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
@PatStLouis
Copy link
Contributor Author

While reviewing, please have a look at the webvh workshop:
https://github.com/OpSecId/acapy/blob/webvh-workshop/docs/demo/WebVH-Workshop.md

Copy link
Collaborator

@loneil loneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I regression tested existing askar wallet tenant setup-config-issue-verify-revoke flows.
Tried out upgrading a wallet after that to webvh.

Went through the webvh workshop (the Tenant UI part at least) and everything worked successfully.

@loneil loneil merged commit 0cbb5db into main Jan 16, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

3 participants