Allow loop cycling through Bullet items#53
Open
antoinedelia wants to merge 5 commits intobchao1:masterfrom
Open
Allow loop cycling through Bullet items#53antoinedelia wants to merge 5 commits intobchao1:masterfrom
antoinedelia wants to merge 5 commits intobchao1:masterfrom
Conversation
If you're on the first item of a Bullet and press the ARROW_UP key, it goes to the last item rather than being blocked on the first one. Same idea when we are on the last item and going down.
antoinedelia
changed the title
rcfox
suggested changes
Oct 15, 2019
Contributor
rcfox
left a comment
rcfox
left a comment
There was a problem hiding this comment.
There are two other classes with moveUp/moveDown. This behaviour should be reflected in those as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you're on the first item of a Bullet and press the
ARROW_UPkey, it goes to the last item rather than being blocked on the first one.Same idea when we are on the last item and going down.
Maybe this could be allowed via a parameter and not defaulted.