Skip to content

Commit e1403ea

Browse files
committed
Merge pull request #8 from sesom42/master
* Try to get icon from executable. If the message loop of the app is faulty, the icon can not be determined with WM_GETICON. * typo in solution file for VS8 * show BugTrap window above the active window * more translation adjustments (German)
2 parents 623d23f + dd130b6 commit e1403ea

File tree

4 files changed

+25
-9
lines changed

4 files changed

+25
-9
lines changed

source/BugTrap.8.sln

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
Microsoft Visual Studio Solution File, Format Version 9.00
33
# Visual Studio 2005
4-
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "BugTrap", "BugTrap.2005.vcproj", "{E8CF1ADA-264A-4127-86C2-FD7057D3792C}"
4+
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "BugTrap", "BugTrap.8.vcproj", "{E8CF1ADA-264A-4127-86C2-FD7057D3792C}"
55
EndProject
66
Global
77
GlobalSection(SolutionConfigurationPlatforms) = preSolution

source/BugTrap.rc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ CAPTION "
9898
FONT 8, "MS Shell Dlg", 0, 0, 0x0
9999
BEGIN
100100
ICON IDI_BUG,IDC_STATIC,7,7,20,20,WS_GROUP
101-
LTEXT "BugTrap - softwarefehler berichterstattung\nVersion 1.3",IDC_VERSION_STRING,34,7,146,16
101+
LTEXT "BugTrap - Softwarefehler Berichterstattung\nVersion 1.3",IDC_VERSION_STRING,34,7,146,16
102102
LTEXT "Copyright � 2005-2009 IntelleSoft",IDC_STATIC,7,32,113,8
103103
LTEXT "http://www.intellesoft.net",IDC_URL,7,42,72,10,WS_TABSTOP
104104
LTEXT " GUI design basierend auf Jim Crafton's BlackBox library",IDC_PORTIONS_COPYRIGHT,7,59,228,10,SS_NOPREFIX | SS_SUNKEN
@@ -128,7 +128,7 @@ FONT 8, "MS Shell Dlg", 0, 0, 0x0
128128
BEGIN
129129
GROUPBOX "Laufende Prozesse beim Absturz",IDC_PROCESS_LIST_FRAME,7,7,250,97,WS_GROUP,WS_EX_TRANSPARENT
130130
CONTROL "",IDC_PROCESS_LIST,"SysListView32",LVS_REPORT | LVS_SINGLESEL | LVS_SHOWSELALWAYS | LVS_ALIGNLEFT | WS_BORDER | WS_TABSTOP,12,17,239,80
131-
GROUPBOX "Vom Gew�hlten Prozess Geladene Module",IDC_PROCESS_MODULES_LIST_FRAME,7,107,250,108,WS_GROUP,WS_EX_TRANSPARENT
131+
GROUPBOX "Vom gew�hlten Prozess geladene Module",IDC_PROCESS_MODULES_LIST_FRAME,7,107,250,108,WS_GROUP,WS_EX_TRANSPARENT
132132
CONTROL "",IDC_PROCESS_MODULES_LIST,"SysListView32",LVS_REPORT | LVS_SINGLESEL | LVS_ALIGNLEFT | WS_BORDER | WS_TABSTOP,12,117,239,92
133133
DEFPUSHBUTTON "Schlie�en",IDCANCEL,264,11,51,14,WS_GROUP
134134
END
@@ -409,8 +409,8 @@ BEGIN
409409
CONTROL "",IDC_FILESLIST,"SysListView32",LVS_REPORT | LVS_SINGLESEL | LVS_SHOWSELALWAYS | LVS_SHAREIMAGELISTS | LVS_ALIGNLEFT | WS_BORDER | WS_GROUP | WS_TABSTOP,3,3,336,55
410410
CONTROL "",IDC_FILEVIEW,"Static",SS_GRAYRECT | WS_BORDER | WS_GROUP | WS_TABSTOP,3,61,336,125
411411
CONTROL "",IDC_FILEFORMAT_FRAME,"Static",SS_ETCHEDFRAME | NOT WS_VISIBLE | WS_GROUP,3,190,122,18,WS_EX_TRANSPARENT
412-
CONTROL "&Textblick",IDC_TEXTVIEW,"Button",BS_AUTORADIOBUTTON | NOT WS_VISIBLE | WS_GROUP | WS_TABSTOP,13,194,44,10
413-
CONTROL "&Hexblick",IDC_HEXVIEW,"Button",BS_AUTORADIOBUTTON | NOT WS_VISIBLE,68,194,42,10
412+
CONTROL "&Text",IDC_TEXTVIEW,"Button",BS_AUTORADIOBUTTON | NOT WS_VISIBLE | WS_GROUP | WS_TABSTOP,13,194,44,10
413+
CONTROL "&Hex",IDC_HEXVIEW,"Button",BS_AUTORADIOBUTTON | NOT WS_VISIBLE,68,194,42,10
414414
CONTROL "",IDC_IMAGE_COMMANDS,"ToolbarWindow32",NOT WS_VISIBLE | 0x4c,3,191,121,16
415415
DEFPUSHBUTTON "Close",IDCANCEL,284,192,50,14,WS_GROUP
416416
END

source/BugTrapUI.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1354,7 +1354,7 @@ static void ExecuteHandlerAction(void)
13541354
{
13551355
if (g_dwFlags & BTF_SHOWADVANCEDUI)
13561356
DialogBox(g_hInstance, MAKEINTRESOURCE(IDD_MAIN_DLG), NULL, MainDlgProc);
1357-
else if (DialogBox(g_hInstance, MAKEINTRESOURCE(IDD_SIMPLE_DLG), NULL, SimpleDlgProc) == TRUE)
1357+
else if (DialogBox(g_hInstance, MAKEINTRESOURCE(IDD_SIMPLE_DLG), GetForegroundWindow(), SimpleDlgProc) == TRUE)
13581358
DialogBox(g_hInstance, MAKEINTRESOURCE(IDD_MAIN_DLG), NULL, MainDlgProc);
13591359
}
13601360
break;

source/ResManager.cpp

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,14 +124,30 @@ CResManager::CResManager(HWND hwndParent)
124124
if (m_hSmallAppIcon == NULL)
125125
{
126126
m_bDestroySmallAppIcon = true;;
127-
m_hSmallAppIcon = (HICON)LoadImage(g_hInstance, MAKEINTRESOURCE(IDI_BUG), IMAGE_ICON, nCXSmallIcon, nCYSmallIcon, LR_DEFAULTCOLOR);
127+
TCHAR szModuleFileName[MAX_PATH];
128+
if (GetModuleFileName(NULL, szModuleFileName, countof(szModuleFileName)))
129+
{
130+
ExtractIconEx(szModuleFileName, 0, NULL, &m_hSmallAppIcon, 1);
131+
}
132+
if (m_hSmallAppIcon == NULL)
133+
{
134+
m_hSmallAppIcon = (HICON)LoadImage(g_hInstance, MAKEINTRESOURCE(IDI_BUG), IMAGE_ICON, nCXSmallIcon, nCYSmallIcon, LR_DEFAULTCOLOR);
135+
}
128136
}
129137
int nCXIcon = GetSystemMetrics(SM_CXICON);
130138
int nCYIcon = GetSystemMetrics(SM_CYICON);
131139
if (m_hBigAppIcon == NULL)
132140
{
133-
m_bDestroyBigAppIcon = true;;
134-
m_hBigAppIcon = (HICON)LoadImage(g_hInstance, MAKEINTRESOURCE(IDI_BUG), IMAGE_ICON, nCXIcon, nCYIcon, LR_DEFAULTCOLOR);
141+
m_bDestroyBigAppIcon = true;
142+
TCHAR szModuleFileName[MAX_PATH];
143+
if (GetModuleFileName(NULL, szModuleFileName, countof(szModuleFileName)))
144+
{
145+
ExtractIconEx(szModuleFileName, 0, &m_hBigAppIcon, NULL, 1);
146+
}
147+
if (m_hBigAppIcon == NULL)
148+
{
149+
m_hBigAppIcon = (HICON)LoadImage(g_hInstance, MAKEINTRESOURCE(IDI_BUG), IMAGE_ICON, nCXIcon, nCYIcon, LR_DEFAULTCOLOR);
150+
}
135151
}
136152
if (m_hBigAppIcon != NULL)
137153
{

0 commit comments

Comments
 (0)