Skip to content

Conversation

@IvanMurzak
Copy link
Contributor

The NuGet package needs to respect a few constraints in order to be listed in the curated list:

  • Add a link to the NuGet package: https://www.nuget.org/packages/com.IvanMurzak.ReflectorNet
  • It must have non-preview versions (e.g 1.0.0 but not 1.0.0-preview.1)
  • It must provide .NETStandard2.0 assemblies as part of its package
  • The lowest version added must be the lowest .NETStandard2.0 version available
  • The package has been tested with the Unity editor
  • The package has been tested with a Unity standalone player
    • if the package is not compatible with standalone player, please add a comment to a Known issues section to the top level readme.md
  • All package dependencies with .NETStandard 2.0 target must be added to the PR (respecting the same rules above)
    • Note that if a future version of the package adds a new dependency, this dependency will have to be added manually as well

Note: The server will be updated only when a new version tag is pushed on the main branch, not necessarily after merging this pull-request.

registry.json Outdated
"version": "0.16.4"
}
}
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore this and please open it with an IDE that uses .editorconfig to avoid this problemas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for that. Working on it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@bdovaz
Copy link
Owner

bdovaz commented Jun 23, 2025

I see that your package depends on Microsoft.CodeAnalysis.CSharp. Is this a real dependency of the package? Or is it a dependency used only to compile the package? I ask because that package has to do with Roslyn analyzers.

@IvanMurzak
Copy link
Contributor Author

I see that your package depends on Microsoft.CodeAnalysis.CSharp. Is this a real dependency of the package? Or is it a dependency used only to compile the package? I ask because that package has to do with Roslyn analyzers.

Hi @bdovaz , yes. It is a real dependency. Or better to say It was. I did the verification and found that the dependency were needed only for a minor operation in the project. I replaced that line of code and removed the dependency in the version 0.1.13.

Original code:

var dictInputParameters = inputParameters?.ToImmutableDictionary(
    keySelector: p => p.name!,
    elementSelector: p => reflector.Deserialize(p, logger)
);

Updated code:

var dictInputParameters = inputParameters?.ToDictionary(
    keySelector: p => p.name!,
    elementSelector: p => reflector.Deserialize(p, logger)
);

@bdovaz bdovaz merged commit 92ec290 into bdovaz:master Jun 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants