Skip to content

Introduced protections against "zip slip" attacks #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bdoyal-getpixee wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Introduced protections against "zip slip" attacks #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@
<artifactId>wink-json4j</artifactId>
<version>1.4</version>
</dependency>
</dependencies>
<dependency>
<groupId>io.github.pixee</groupId>
<artifactId>java-security-toolkit</artifactId>
</dependency>
</dependencies>

<profiles>
<profile>
Expand Down Expand Up @@ -139,4 +143,16 @@
<tag>HEAD</tag>
</scm>

<dependencyManagement>
<dependencies>
<dependency>
<groupId>io.github.pixee</groupId>
<artifactId>java-security-toolkit</artifactId>
<version>${versions.java-security-toolkit}</version>
</dependency>
</dependencies>
</dependencyManagement>
<properties>
<versions.java-security-toolkit>1.2.0</versions.java-security-toolkit>
</properties>
</project>
3 changes: 2 additions & 1 deletion src/main/java/com/hcl/appscan/sdk/utils/ArchiveUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

package com.hcl.appscan.sdk.utils;

import io.github.pixee.security.ZipSecurity;
import java.io.BufferedInputStream;
import java.io.BufferedOutputStream;
import java.io.File;
Expand Down Expand Up @@ -47,7 +48,7 @@ public class ArchiveUtil {
public static void unzip(File source, File destDir) throws IOException {

FileInputStream input = new FileInputStream(source);
ZipInputStream zip = new ZipInputStream(new BufferedInputStream(input));
ZipInputStream zip = ZipSecurity.createHardenedInputStream(new BufferedInputStream(input));
destDir.mkdirs();

ZipEntry entry = null;
Expand Down