greybus: subsys: implement SDIO protocol support using Zephyr SDHC API (#89)#91
Open
VAIBHAVIBOBDE wants to merge 2 commits intobeagleboard:mainfrom
Open
greybus: subsys: implement SDIO protocol support using Zephyr SDHC API (#89)#91VAIBHAVIBOBDE wants to merge 2 commits intobeagleboard:mainfrom
VAIBHAVIBOBDE wants to merge 2 commits intobeagleboard:mainfrom
Conversation
Ayush1325
requested changes
Feb 2, 2026
| @@ -0,0 +1,7 @@ | |||
| common: | |||
Member
There was a problem hiding this comment.
Tests need to be done on native_sim which can actually run in CI
Ayush1325
requested changes
Feb 3, 2026
Member
Ayush1325
left a comment
Ayush1325
left a comment
There was a problem hiding this comment.
This PR uses the incorrect APIs. SDHC is not SDIO.
| - beagleconnect_freedom | ||
| - native_sim | ||
| integration_platforms: | ||
| - beagleconnect_freedom |
Member
There was a problem hiding this comment.
Bcf does not even have SDIO. No idea why you thought to include it here.
| return msg; | ||
| } | ||
|
|
||
| ZTEST(greybus_sdio_tests, test_protocol_version) |
| zassert_true(resp_data->max_blk_size > 0, "Max block size should be > 0"); | ||
|
|
||
| gb_message_dealloc(resp.msg); | ||
| } |
Member
There was a problem hiding this comment.
At least test transfers and events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements the SDIO (Secure Digital Input Output) Protocol for the Greybus subsystem in Zephyr. The implementation utilizes the Zephyr SDHC (Secure Digital Host Controller) API, providing a hardware-independent way to handle SDIO communications.
Key Implementation Details
SDIO Translation: Created subsys/greybus/sdio.c to translate Greybus operations into Zephyr SDHC commands.
Deferred Execution: Introduced a mechanism to handle split Command/Data requests. This ensures that the protocol does not block the system during complex data transfers.
Kconfig Integration: Added Kconfig.sdio and updated subsys/greybus/Kconfig to allow developers to enable/disable SDIO support as needed.
Integration Tests: Created a comprehensive test suite in tests/greybus/integration/sdio/ to verify protocol stability.
Files Modified/Added
subsys/greybus/sdio.c
subsys/greybus/Kconfig
subsys/greybus/Kconfig.sdio
tests/greybus/integration/sdio/src/main.c
tests/greybus/integration/sdio/testcase.yaml
TEST_INSTRUCTIONS.md
Testing
Tests were structured to run via west. Detailed steps for environment setup and execution are provided in the included TEST_INSTRUCTIONS.md.
Fixes issue: #89