Allow host module resolution to be overridden#153
Open
akrantz01 wants to merge 2 commits intobearcove:mainfrom
Open
Allow host module resolution to be overridden#153akrantz01 wants to merge 2 commits intobearcove:mainfrom
akrantz01 wants to merge 2 commits intobearcove:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #143
Adds the equivalent of the
resolveJsandresolveWasmfor the host interface so that arborium can be used fully without a CDN. Also exports thearborium_host.jsandarborium_host_bg.wasmfiles in thepackage.jsonso that dynamic imports work with Node.I opted to duplicate
resolveJsandresolveWasmasresolveHostJsandresolveHostWasmrespectively. I considered repurposing thelanguageattribute and denoting"host"as a special value. However, I figured this would be the clearest and allow any existing users ofresolveJsandresolveWasmto keep their implementations unchanged and without any special cases.I believe this should completely resolve #143 since now every part of the dynamic loading is now customizable at runtime.