Skip to content

Emitting "source" event when a source is scheduled #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Emitting "source" event when a source is scheduled #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9002d0f
Emitting "source" event when a source is scheduled
AdelaFoofur82 Oct 23, 2024
c02318f
We don't stop the source before it ends
AdelaFoofur82 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/beatbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ export class Beatbox extends EventEmitter {
source.connect(this._audioContext!.destination);
}

this.emit("source", { source, time });
source.start(time);

const clear = () => {
Expand Down Expand Up @@ -373,8 +374,9 @@ export class Beatbox extends EventEmitter {
if (instr && (instr.volume == null || instr.volume > 0)) {
let time = this._referenceTime! + (this._position - this._upbeat) * this._strokeLength / 1000;

if(this._lastInstrumentStrokes[instr.key])
this._lastInstrumentStrokes[instr.key].stop(time);
// We avoid the sound to stop before it is required to sound again. We let it end by itself
// if(this._lastInstrumentStrokes[instr.key])
// this._lastInstrumentStrokes[instr.key].stop(time);

const sound = this._scheduleSound(instr, time);
this._lastInstrumentStrokes[instr.key] = sound;
Expand Down