Skip to content

add function to get IP representation of subnet mask#95

Open
drahnieR wants to merge 4 commits intobeaugunderson:masterfrom
drahnieR:subnetMaskIp-v4
Open

add function to get IP representation of subnet mask#95
drahnieR wants to merge 4 commits intobeaugunderson:masterfrom
drahnieR:subnetMaskIp-v4

Conversation

@drahnieR
Copy link

@drahnieR drahnieR commented Jan 3, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 3, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1fe6b67) to head (0bac360).
Report is 126 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #95   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          623       626    +3     
  Branches        94        94           
=========================================
+ Hits           623       626    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beaugunderson
Copy link
Owner

beaugunderson commented Jan 5, 2020

@drahnieR thanks, this is a helpful addition--do you mind adding some tests in test/functionality-v4-test.js?

additionally, we should probably return .correctForm() instead of .address

@drahnieR
Copy link
Author

drahnieR commented Jan 6, 2020

Ok, that was a wired failure, but I think i've got the Travis build passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants