Store last editor and verified_by on teacher model#341
Open
cycomachead wants to merge 15 commits intomainfrom
Open
Store last editor and verified_by on teacher model#341cycomachead wants to merge 15 commits intomainfrom
cycomachead wants to merge 15 commits intomainfrom
Conversation
Member
cycomachead
commented
Mar 15, 2025
- Refactor create/update in teachers controlller
- Refactor teacher#update to simplify setting needs review status
- Further simplify the teachers_controller update
- delint
- Add migration to add user last edited attrs to teacher model
- Run migration to add new attributes to teacher
- Get last_editor id saving / working correctly.
- Save verified by when updating teacher verification
- track verified_by and fix typo
- fixup duplicate render on #create
* create no longer attempts to update a teacher record * edit better protects against denied users
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #341 +/- ##
==========================================
- Coverage 70.20% 70.17% -0.03%
==========================================
Files 28 29 +1
Lines 1000 1026 +26
==========================================
+ Hits 702 720 +18
- Misses 298 306 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* main: Bump elliptic from 6.5.4 to 6.6.0 Bump rexml from 3.3.6 to 3.3.9 Bump http-proxy-middleware from 2.0.6 to 2.0.7 Bump express from 4.19.2 to 4.21.0 Bump puma from 5.6.8 to 5.6.9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.