Skip to content

Store last editor and verified_by on teacher model#341

Open
cycomachead wants to merge 15 commits intomainfrom
add-user-verification-details
Open

Store last editor and verified_by on teacher model#341
cycomachead wants to merge 15 commits intomainfrom
add-user-verification-details

Conversation

@cycomachead
Copy link
Copy Markdown
Member

  • Refactor create/update in teachers controlller
  • Refactor teacher#update to simplify setting needs review status
  • Further simplify the teachers_controller update
  • delint
  • Add migration to add user last edited attrs to teacher model
  • Run migration to add new attributes to teacher
  • Get last_editor id saving / working correctly.
  • Save verified by when updating teacher verification
  • track verified_by and fix typo
  • fixup duplicate render on #create

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 15, 2025

Codecov Report

Attention: Patch coverage is 89.83051% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.17%. Comparing base (0760500) to head (167885c).

Files with missing lines Patch % Lines
app/controllers/teachers_controller.rb 76.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   70.20%   70.17%   -0.03%     
==========================================
  Files          28       29       +1     
  Lines        1000     1026      +26     
==========================================
+ Hits          702      720      +18     
- Misses        298      306       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* main:
  Bump elliptic from 6.5.4 to 6.6.0
  Bump rexml from 3.3.6 to 3.3.9
  Bump http-proxy-middleware from 2.0.6 to 2.0.7
  Bump express from 4.19.2 to 4.21.0
  Bump puma from 5.6.8 to 5.6.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant