making personal website a required field + tests#389
Open
ronikriger wants to merge 26 commits intobeautyjoy:mainfrom
Open
making personal website a required field + tests#389ronikriger wants to merge 26 commits intobeautyjoy:mainfrom
ronikriger wants to merge 26 commits intobeautyjoy:mainfrom
Conversation
Implement school merging
making personal website a required field + tests
Revert "Implement school merging"
Author
Update member1 details in info.yml
cycomachead
requested changes
Mar 6, 2026
Member
cycomachead
left a comment
cycomachead
left a comment
There was a problem hiding this comment.
Thanks! Two minor tweaks but this is good.
Author
|
Should be ready to be merdged I adressed both issues: |
Sync fork and golden repo: Update nokigiri
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
making personal website a required field + tests
Who authored this PR?
ronikriger
How should this PR be tested?
Run Rspec and cucumber testsmaking personal website a required field + tests
What this PR does:
making personal website a required field + tests
Who authored this PR?
ronikriger
How should this PR be tested?
Run Rspec and cucumber tests