Iteration 2 - Add school location to teacher view#390
Open
kienthuynh wants to merge 27 commits intobeautyjoy:mainfrom
Open
Iteration 2 - Add school location to teacher view#390kienthuynh wants to merge 27 commits intobeautyjoy:mainfrom
kienthuynh wants to merge 27 commits intobeautyjoy:mainfrom
Conversation
Implement school merging
making personal website a required field + tests
Revert "Implement school merging"
Update member1 details in info.yml
Sync fork and golden repo: Update nokigiri
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature just adds school location to the teacher view and modifies a test for the teacher view to make sure it displays the location.
There are only two diffs that are related to this feature (the rest are from other features that haven't been merged into golden repo):