Conversation
… visual novels Added 7 new test functions with 60+ popular anime/VN characters including: - test_popular_anime_vn_characters: 60+ characters from Jujutsu Kaisen, Demon Slayer, Steins;Gate, Code Geass, Attack on Titan, My Hero Academia, Fate, and more - test_complex_kanji_names: Complex multi-character names and unique kanji combinations - test_long_katakana_names: Foreign names in katakana (shorthands, full names) - test_special_character_sequences: Small kana, prolonged sounds, special katakana - test_historical_and_traditional_names: Samurai-era and historical character names - test_mixed_cjk_characters: Names mixing Japanese scripts and spacing - test_unusual_given_names: Unique and unconventional name patterns - test_phonetic_name_variations: Hiragana/katakana phonetic spellings - test_visual_novel_specific_names: Characters from Clannad, Danganronpa, Umineko, etc. - test_western_inspired_anime_names: Transliterated Western names in Japanese - test_year_2024_2025_popular_anime: Recent popular anime (Frieren, The Apothecary Diaries) All tests verify: ✓ Non-empty readings generated ✓ No invalid iteration marks (々) in output ✓ Correct family/given name splitting with hints ✓ Proper kana conversion for kanji names ✓ Mixed script handling Tests now cover: - 648 total test cases (previously 641) - Characters from 20+ anime/VN franchises - Various name structures and patterns - Edge cases and special characters https://claude.ai/code/session_016ZswpqXbL4edMRConiBxCo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 7 new test functions with 60+ popular anime/VN characters including:
Steins;Gate, Code Geass, Attack on Titan, My Hero Academia, Fate, and more
All tests verify:
✓ Non-empty readings generated
✓ No invalid iteration marks (々) in output
✓ Correct family/given name splitting with hints
✓ Proper kana conversion for kanji names
✓ Mixed script handling
Tests now cover:
https://claude.ai/code/session_016ZswpqXbL4edMRConiBxCo