Skip to content

Conversation

@Integral-Tech
Copy link
Contributor

@Integral-Tech Integral-Tech commented Nov 21, 2024

Fixes issue #695

@Integral-Tech
Copy link
Contributor Author

@bee-san I have just fixed the failed workflow in my latest commit, please retrigger it :)

@bee-san
Copy link
Owner

bee-san commented Nov 24, 2024

error[E0599]: no method named `signal` found for struct `ExitStatus` in the current scope
22
   --> src\scripts\mod.rs:294:46
23
    |
24
294 |                 None if cfg!(unix) => status.signal().unwrap(),
25
    |                                              ^^^^^^ method not found in `ExitStatus`

Windows doesn't like this? :(

@Integral-Tech
Copy link
Contributor Author

error[E0599]: no method named `signal` found for struct `ExitStatus` in the current scope
22
   --> src\scripts\mod.rs:294:46
23
    |
24
294 |                 None if cfg!(unix) => status.signal().unwrap(),
25
    |                                              ^^^^^^ method not found in `ExitStatus`

Windows doesn't like this? :(

Yes, the signal() method is Unix only

@Integral-Tech
Copy link
Contributor Author

Integral-Tech commented Nov 24, 2024

@bee-san I just switched to another method of conditional compilation in my latest commit :)

@bee-san
Copy link
Owner

bee-san commented Nov 25, 2024

thanks so much!!

@bee-san bee-san merged commit b039db7 into bee-san:master Nov 25, 2024
4 checks passed
@bee-san
Copy link
Owner

bee-san commented Nov 25, 2024

Oh I forgot to say! Please don't force push in the future, it is slightly annoying to work out what's changed per commit 😅 (When you make a change to fix something, I go to your latest commit to see what the fix was. Because it was force-pushed, I do not know what specifically changed so I have to read the full change again)

Thank you so much for your contribution!!

@Integral-Tech Integral-Tech deleted the refactor-std-process branch November 25, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants