feat: add address exclusion flag (#718) #719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PsypherPunk
approved these changes
Jan 20, 2025
Collaborator
PsypherPunk
left a comment
PsypherPunk
left a comment
There was a problem hiding this comment.
I like it—verified locally and LGTM! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #718, this PR adds an option to exclude single addresses, hosts or CIDRs from the list of addresses to allow for a more granular selection of target addresses to be scanned.
The new optional argument can be used with
-xor--exclude-addresses. The implementation was done by filtering the final list of parsed addresses against the list of exclusions (after they have been parsed and optionally resolved as well). I've added three tests to make sure it works as intended as well.