add customisable script path to script config #738
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@Atom1cByte, could you rebase off |
PsypherPunk
reviewed
Feb 3, 2025
Collaborator
PsypherPunk
left a comment
PsypherPunk
left a comment
There was a problem hiding this comment.
This looks good; a useful addition would be to:
- extend the
fixtures/test_rustscan_scripts.tomlexample to include the newdirectoryconfig. - add a test to this file to verify that it's being parsed correctly
Otherwise, this is nice.
Owner
|
I am in favour but agree about tests, this is the kinda thing we'd forget to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't added a command line argument for it, but I was wondering if it would be better to just add a command line argument for the script config path, if that doesn't already exist and have that config just point to the scripts.